DRAFT: Patch for missing TFM trimming change in Roslyn #15961
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmitche
approved these changes
Mar 31, 2023
| From: Nikola Milosavljevic <[email protected]> | ||
| Date: Thu, 30 Mar 2023 22:30:25 +0000 | ||
| Subject: [PATCH] Use Content for non-TFM specific items | ||
|
|
Member
There was a problem hiding this comment.
Please include a "Backport: <PR/Issue>" comment on all patches. This is very helpful for tracking purposes.
MichaelSimons
approved these changes
Mar 31, 2023
Member
|
@NikolaMilosavljevic - Is this necessary anymore, can it be closed now? |
Member
Author
Roslyn changes are flowing with this, currently failing, PR: #16033 Once that PR is merged, I will close this PR and update the tracking issue: dotnet/source-build#3371 |
Member
Author
|
Not needed anymore - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch brings the missing change, needed for TFM trimming work: dotnet/roslyn#67206
That change is now in roslyn's
release/dev17.6-vs-depsbranch and is currently flowing tosdkwith this PR: dotnet/sdk#31499This PR is optional and marked as WIP.