[main] Update dependencies from dotnet/roslyn #31499

dotnet-maestro · 2023-03-28T21:36:54Z

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

Subscription: 03acf5d2-59bd-494b-c390-08d8e9750d9d
Build: 20230410.15
Date Produced: April 11, 2023 5:23:40 AM UTC
Commit: a10bbf218cbd333e13a5387661c73f9b4077bd48
Branch: refs/heads/release/dev17.6-vs-deps

Updates:
- Microsoft.CodeAnalysis: from 4.6.0-2.23177.13 to 4.6.0-3.23210.15
- Microsoft.CodeAnalysis.CSharp: from 4.6.0-2.23177.13 to 4.6.0-3.23210.15
- Microsoft.CodeAnalysis.CSharp.CodeStyle: from 4.6.0-2.23177.13 to 4.6.0-3.23210.15
- Microsoft.CodeAnalysis.CSharp.Features: from 4.6.0-2.23177.13 to 4.6.0-3.23210.15
- Microsoft.CodeAnalysis.CSharp.Workspaces: from 4.6.0-2.23177.13 to 4.6.0-3.23210.15
- Microsoft.CodeAnalysis.Workspaces.MSBuild: from 4.6.0-2.23177.13 to 4.6.0-3.23210.15
- Microsoft.Net.Compilers.Toolset: from 4.6.0-2.23177.13 to 4.6.0-3.23210.15

…328.7 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset From Version 4.6.0-2.23177.13 -> To Version 4.6.0-2.23178.7

…328.8 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset From Version 4.6.0-2.23177.13 -> To Version 4.6.0-2.23178.8

v-wuzhai · 2023-03-29T06:50:28Z

/azp run

azure-pipelines · 2023-03-29T06:50:38Z

Azure Pipelines successfully started running 1 pipeline(s).

…328.21 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset From Version 4.6.0-2.23177.13 -> To Version 4.6.0-3.23178.21

dotnet-maestro · 2023-03-29T10:12:49Z

Notification for subscribed users from https://github.com/dotnet/roslyn:

@dotnet/roslyn-infrastructure

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

This pull request contains changes from your source repo (https://github.com/dotnet/roslyn) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
For more details, please read the Arcade Darc documentation

marek-safar · 2023-03-29T14:08:00Z

It looks like there was a change in Roslyn API about how empty types are written.

@jaredpar to double check if that's expected.

jaredpar · 2023-03-29T14:29:18Z

@CyrusNajmabadi, @333fred did we change how the syntax formatter is emitting empty types? This delta in the test in coming from the GenAPI layer (which uses the formatte). Essentially looks like empty types had a change here:

// old
struct S { }
// new
struct S
{
}

CyrusNajmabadi · 2023-03-29T14:41:15Z

Might have been fallout from a @DoctorKrolic change? I can look when I get into work. Seems like a totally reasonable change to me though

dotnet-maestro · 2023-03-29T19:15:48Z

Notification for subscribed users from https://github.com/dotnet/roslyn:

@dotnet/roslyn-infrastructure

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

This pull request contains changes from your source repo (https://github.com/dotnet/roslyn) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
For more details, please read the Arcade Darc documentation

dotnet-maestro · 2023-03-29T19:26:04Z

Notification for subscribed users from https://github.com/dotnet/roslyn:

@dotnet/roslyn-infrastructure

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

This pull request contains changes from your source repo (https://github.com/dotnet/roslyn) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
For more details, please read the Arcade Darc documentation

dotnet-maestro · 2023-03-29T19:31:16Z

Notification for subscribed users from https://github.com/dotnet/roslyn:

@dotnet/roslyn-infrastructure

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

This pull request contains changes from your source repo (https://github.com/dotnet/roslyn) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
For more details, please read the Arcade Darc documentation

…329.15 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset From Version 4.6.0-2.23177.13 -> To Version 4.6.0-3.23179.15

…330.6 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset From Version 4.6.0-2.23177.13 -> To Version 4.6.0-3.23180.6

…331.6 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset From Version 4.6.0-2.23177.13 -> To Version 4.6.0-3.23181.6

…331.8 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset From Version 4.6.0-2.23177.13 -> To Version 4.6.0-3.23181.8

nagilson · 2023-04-05T22:10:04Z

@NikolaMilosavljevic Is the other PR in a good state so we can merge that, and then merge this?

NikolaMilosavljevic · 2023-04-05T23:01:38Z

@NikolaMilosavljevic Is the other PR in a good state so we can merge that, and then merge this?

Can you share the link to other PR? If it's this one (dotnet/installer#15961) then it's not needed, and I will close it once you merge this PR.

nagilson · 2023-04-05T23:41:16Z

Indeed, that was the PR. So ... this formatting change is expected and we just need to update the expected output?

NikolaMilosavljevic · 2023-04-06T00:35:06Z

Indeed, that was the PR. So ... this formatting change is expected and we just need to update the expected output?

I'm not sure about the formatting change - that is likely unrelated. My PR is simply patching source-build with a packaging change made by @mmitche in roslyn repo, few weeks ago: dotnet/roslyn#67206

nagilson · 2023-04-06T16:39:22Z

@CyrusNajmabadi May you respond to the above please and fix up this PR if you have confirmed the behavior change was desired?

CyrusNajmabadi · 2023-04-06T19:35:00Z

I really don't have any context on that. I don't see any problem though with things getting formatted this way, so change seems fine to me.

…406.9 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset From Version 4.6.0-2.23177.13 -> To Version 4.6.0-3.23206.9

nagilson · 2023-04-07T17:15:05Z

@dotnet/roslyn-infrastructure @mmitche 9 new prebuilts discovered here. Is this expected?

…407.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset From Version 4.6.0-2.23177.13 -> To Version 4.6.0-3.23207.4

…407.13 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset From Version 4.6.0-2.23177.13 -> To Version 4.6.0-3.23207.13

joeloff · 2023-04-10T17:50:47Z

Looks like a prebuilt is failing source build: System.Composition.7.0.0

@MichaelSimons what is the guidance around this, is there some general process we need to follow?

MichaelSimons · 2023-04-10T17:54:56Z

Looks like a prebuilt is failing source build: System.Composition.7.0.0

@MichaelSimons what is the guidance around this, is there some general process we need to follow?

http://aka.ms/dotnet/prebuilts

mmitche · 2023-04-10T18:02:01Z

Okay here's something interesting. The generator claimed to have not built System.Composition because it only builds for net4* and netcoreapp2.0 TFMs.

MichaelSimons · 2023-04-10T18:03:59Z

Okay here's something interesting. The generator claimed to have not built System.Composition because it only builds for net4* and netcoreapp2.0 TFMs.

Would be nice to know what TFM is required by roslyn. Perhaps it is a TFM that is filtered out by the tooling.

mmitche · 2023-04-10T18:04:38Z

Oh! No, I'm incorrect. It's a text only package. What do we do about those?

MichaelSimons · 2023-04-10T18:05:20Z

Oh! No, I'm incorrect. It's a text only package. What do we do about those?

Add it to SBRP. You need to use the -type text option.

joeloff · 2023-04-10T18:14:02Z

Oh! No, I'm incorrect. It's a text only package. What do we do about those?

Text only? You mean no code, just content files or something else?

MichaelSimons · 2023-04-10T18:16:28Z

Oh! No, I'm incorrect. It's a text only package. What do we do about those?

Text only? You mean no code, just content files or something else?

The package contains no binaries, only text based content files.

mmitche · 2023-04-10T19:51:31Z

dotnet/source-build-reference-packages#619

joeloff · 2023-04-10T23:29:23Z

dotnet/source-build-reference-packages#619

So we wait for SB PR to flow, or should I exclude the package for now to unblock this PR?

v-wuzhai · 2023-04-11T01:59:00Z

/azp run

azure-pipelines · 2023-04-11T01:59:14Z

Azure Pipelines successfully started running 1 pipeline(s).

…410.15 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset From Version 4.6.0-2.23177.13 -> To Version 4.6.0-3.23210.15

NikolaMilosavljevic · 2023-04-11T15:44:53Z

dotnet/source-build-reference-packages#619

There are still no PRs for updating Microsoft.SourceBuild.Intermediate.source-build-reference-packages. There is a daily subscription for flowing https://github.com/dotnet/source-build-reference-packages to dotnet/sdk. However, last update was on 4/5. @mmitche is there a way to check why SBRP stopped flowing to this repo?

NikolaMilosavljevic · 2023-04-11T16:40:07Z

dotnet/source-build-reference-packages#619

There are still no PRs for updating Microsoft.SourceBuild.Intermediate.source-build-reference-packages. There is a daily subscription for flowing https://github.com/dotnet/source-build-reference-packages to dotnet/sdk. However, last update was on 4/5. @mmitche is there a way to check why SBRP stopped flowing to this repo?

SBRP flow is now in progress: #31707. After that's merged, this PR would need to be rebased.

mmitche · 2023-04-11T17:05:57Z

I think these are Maestro timeouts? Not sure really....maybe related to legacy coherency dotnet/arcade-services#2687.

/cc @dotnet/dnceng

riarenas · 2023-04-11T17:09:07Z

Yes, the daily dependency updates are not happening. Maestro is timing out dotnet/arcade#13109.

I triggered all the daily subscriptions manually today. Is #31707 the one you were looking for?

ghost added Area-CodeFlow untriaged Request triage from a team member labels Mar 28, 2023

dotnet-maestro bot added 2 commits March 30, 2023 07:57

NikolaMilosavljevic mentioned this pull request Mar 30, 2023

DRAFT: Patch for missing TFM trimming change in Roslyn dotnet/installer#15961

Closed

dotnet-maestro bot added 2 commits April 1, 2023 00:28

adjust to new struct formatting xd

c7f549a

nagilson enabled auto-merge April 6, 2023 21:51

nagilson approved these changes Apr 6, 2023

View reviewed changes

mmitche and others added 3 commits April 7, 2023 14:00

Update SBRP

41f1d68

lewing closed this Apr 11, 2023

auto-merge was automatically disabled April 11, 2023 05:38
Pull request was closed

lewing reopened this Apr 11, 2023

lewing added the source-build label Apr 11, 2023

NikolaMilosavljevic closed this Apr 11, 2023

NikolaMilosavljevic reopened this Apr 11, 2023

Merge branch 'main' into darc-main-e5b4c870-f805-4f58-8338-1cc601e2fad0

f7a6cc4

NikolaMilosavljevic mentioned this pull request Apr 11, 2023

TFM trimming - flow of changes into installer repo dotnet/source-build#3371

Closed

10 tasks

dotnet-maestro bot merged commit dd0b02f into main Apr 11, 2023

dotnet-maestro bot deleted the darc-main-e5b4c870-f805-4f58-8338-1cc601e2fad0 branch April 11, 2023 21:37

[main] Update dependencies from dotnet/roslyn #31499

[main] Update dependencies from dotnet/roslyn #31499

Uh oh!

Conversation

dotnet-maestro bot commented Mar 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

From https://github.com/dotnet/roslyn

Uh oh!

v-wuzhai commented Mar 29, 2023

Uh oh!

azure-pipelines bot commented Mar 29, 2023

Uh oh!

dotnet-maestro bot commented Mar 29, 2023

Notification for subscribed users from https://github.com/dotnet/roslyn:

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

Uh oh!

marek-safar commented Mar 29, 2023

Uh oh!

jaredpar commented Mar 29, 2023

Uh oh!

CyrusNajmabadi commented Mar 29, 2023

Uh oh!

dotnet-maestro bot commented Mar 29, 2023

Notification for subscribed users from https://github.com/dotnet/roslyn:

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

Uh oh!

dotnet-maestro bot commented Mar 29, 2023

Notification for subscribed users from https://github.com/dotnet/roslyn:

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

Uh oh!

dotnet-maestro bot commented Mar 29, 2023

Notification for subscribed users from https://github.com/dotnet/roslyn:

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

Uh oh!

nagilson commented Apr 5, 2023

Uh oh!

NikolaMilosavljevic commented Apr 5, 2023

Uh oh!

nagilson commented Apr 5, 2023

Uh oh!

NikolaMilosavljevic commented Apr 6, 2023

Uh oh!

nagilson commented Apr 6, 2023

Uh oh!

CyrusNajmabadi commented Apr 6, 2023

Uh oh!

nagilson commented Apr 7, 2023

Uh oh!

joeloff commented Apr 10, 2023

Uh oh!

MichaelSimons commented Apr 10, 2023

Uh oh!

mmitche commented Apr 10, 2023

Uh oh!

MichaelSimons commented Apr 10, 2023

Uh oh!

mmitche commented Apr 10, 2023

Uh oh!

MichaelSimons commented Apr 10, 2023

Uh oh!

joeloff commented Apr 10, 2023

Uh oh!

MichaelSimons commented Apr 10, 2023

Uh oh!

mmitche commented Apr 10, 2023

Uh oh!

joeloff commented Apr 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

v-wuzhai commented Apr 11, 2023

Uh oh!

azure-pipelines bot commented Apr 11, 2023

Uh oh!

NikolaMilosavljevic commented Apr 11, 2023

Uh oh!

NikolaMilosavljevic commented Apr 11, 2023

Uh oh!

mmitche commented Apr 11, 2023

Uh oh!

riarenas commented Apr 11, 2023

dotnet-maestro bot commented Mar 28, 2023 •

edited

Loading

joeloff commented Apr 10, 2023 •

edited

Loading