Skip to content

Support Url and Message parameters in RequiresPreviewFeaturesAttribute #5502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buyaa-n merged 26 commits into from
Oct 7, 2021
Merged

Support Url and Message parameters in RequiresPreviewFeaturesAttribute #5502

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
947927a
First cut of message and URL support. Needs to be cleaned up
Sep 16, 2021
0dac989
GeneralPreviewFeatureAttributeRule and unit test changes
Sep 17, 2021
1d70485
ImplementsPreviewInterfaceRule and unit test changes
Sep 17, 2021
e4105f9
UsesPreviewTypeParameterRule and unit test changes
Sep 17, 2021
4232a34
Everything else
Sep 17, 2021
3ec9901
Clean up
Sep 17, 2021
1732835
Fix test failures in PCA
buyaa-n Sep 20, 2021
06cd8cc
Self review + unit tests
Sep 20, 2021
1bc3edf
Make method static
Sep 21, 2021
712bfbc
First cut of addressing comments
Sep 23, 2021
5fefe10
Before reordering args
Sep 23, 2021
722716e
Checkpoint
Sep 23, 2021
eb77b71
All unit tests pass
Sep 24, 2021
f94f4b9
MInor cleanup
Sep 24, 2021
7e578a0
More cleanup
Sep 24, 2021
86bb96c
Before unit test regex changes
Sep 24, 2021
4eec26c
Bug fix and all unit tests pass
Sep 24, 2021
abbf59f
sq
Sep 24, 2021
969faa1
sq
Sep 24, 2021
7df6264
Address comments
Sep 28, 2021
98ee43d
sq
Sep 28, 2021
91aae98
pack
Sep 28, 2021
70151db
Merge conflicts
buyaa-n Oct 6, 2021
96db9b0
Omit quotes around urls in diagnostic messages
jeffhandley Oct 7, 2021
cd84f30
Formatting tweaks
jeffhandley Oct 7, 2021
4339b4a
Merge conflicts
buyaa-n Oct 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean up
  • Loading branch information
Prashanth Govindarajan committed Sep 17, 2021
commit 3ec990124690ac4cc49fe7430dcd50f61a59bd55
3 changes: 0 additions & 3 deletions src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1795,9 +1795,6 @@
<data name="DoNotAlwaysSkipTokenValidationInDelegatesMessage" xml:space="preserve">
<value>The {0} is set to a function that is always returning true. By setting the validation delegate, you are overriding default validation and by always returning true, this validation is completely disabled.</value>
</data>
<data name="CustomPreviewAPIMessage" xml:space="preserve">
<value>'{0}'. '{1}'</value>
</data>
<data name="DetectPreviewFeaturesDiagnosticMessage" xml:space="preserve">
<value>'{0}' '{1}'</value>
</data>
Expand Down
87 changes: 29 additions & 58 deletions src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/DetectPreviewFeatureAnalyzer.cs
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 0 additions & 5 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,6 @@
<target state="translated">, </target>
<note>Separator used for separating list of platform names: {API} is only supported on: {‘windows’, ‘browser’, ‘linux’}</note>
</trans-unit>
<trans-unit id="CustomPreviewAPIMessage">
<source>'{0}'. '{1}'</source>
<target state="new">'{0}'. '{1}'</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInDeserializableObjectGraphMessage">
<source>When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}</source>
<target state="translated">Při deserializaci nedůvěryhodného vstupu není deserializace objektu {0} bezpečná. Objekt {1} je buď objektem {0}, nebo je z tohoto objektu odvozený.</target>
Expand Down
5 changes: 0 additions & 5 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,6 @@
<target state="translated">, </target>
<note>Separator used for separating list of platform names: {API} is only supported on: {‘windows’, ‘browser’, ‘linux’}</note>
</trans-unit>
<trans-unit id="CustomPreviewAPIMessage">
<source>'{0}'. '{1}'</source>
<target state="new">'{0}'. '{1}'</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInDeserializableObjectGraphMessage">
<source>When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}</source>
<target state="translated">Beim Deserialisieren einer nicht vertrauenswürdigen Eingabe ist die Deserialisierung eines {0}-Objekts unsicher. "{1}" ist entweder "{0}" oder davon abgeleitet.</target>
Expand Down
5 changes: 0 additions & 5 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,6 @@
<target state="translated">, </target>
<note>Separator used for separating list of platform names: {API} is only supported on: {‘windows’, ‘browser’, ‘linux’}</note>
</trans-unit>
<trans-unit id="CustomPreviewAPIMessage">
<source>'{0}'. '{1}'</source>
<target state="new">'{0}'. '{1}'</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInDeserializableObjectGraphMessage">
<source>When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}</source>
<target state="translated">Cuando se deserializa una entrada que no es de confianza, no es segura la deserialización de un objeto {0}. "{1}" es {0} o se deriva de este.</target>
Expand Down
5 changes: 0 additions & 5 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,6 @@
<target state="translated">, </target>
<note>Separator used for separating list of platform names: {API} is only supported on: {‘windows’, ‘browser’, ‘linux’}</note>
</trans-unit>
<trans-unit id="CustomPreviewAPIMessage">
<source>'{0}'. '{1}'</source>
<target state="new">'{0}'. '{1}'</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInDeserializableObjectGraphMessage">
<source>When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}</source>
<target state="translated">Quand vous désérialisez une entrée non fiable, la désérialisation d'un objet {0} n'est pas une action sécurisée. '{1}' est égal à ou dérive de {0}</target>
Expand Down
5 changes: 0 additions & 5 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,6 @@
<target state="translated">, </target>
<note>Separator used for separating list of platform names: {API} is only supported on: {‘windows’, ‘browser’, ‘linux’}</note>
</trans-unit>
<trans-unit id="CustomPreviewAPIMessage">
<source>'{0}'. '{1}'</source>
<target state="new">'{0}'. '{1}'</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInDeserializableObjectGraphMessage">
<source>When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}</source>
<target state="translated">Quando si deserializza input non attendibile, la deserializzazione di un oggetto {0} non è sicura. '{1}' è {0} o deriva da esso</target>
Expand Down
5 changes: 0 additions & 5 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.ja.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,6 @@
<target state="translated">, </target>
<note>Separator used for separating list of platform names: {API} is only supported on: {‘windows’, ‘browser’, ‘linux’}</note>
</trans-unit>
<trans-unit id="CustomPreviewAPIMessage">
<source>'{0}'. '{1}'</source>
<target state="new">'{0}'. '{1}'</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInDeserializableObjectGraphMessage">
<source>When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}</source>
<target state="translated">信頼されていない入力を逆シリアル化する場合、{0} オブジェクトの逆シリアル化は安全ではありません。'{1}' は {0} であるか、それから派生しています</target>
Expand Down
5 changes: 0 additions & 5 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.ko.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,6 @@
<target state="translated">, </target>
<note>Separator used for separating list of platform names: {API} is only supported on: {‘windows’, ‘browser’, ‘linux’}</note>
</trans-unit>
<trans-unit id="CustomPreviewAPIMessage">
<source>'{0}'. '{1}'</source>
<target state="new">'{0}'. '{1}'</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInDeserializableObjectGraphMessage">
<source>When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}</source>
<target state="translated">신뢰할 수 없는 입력을 역직렬화하는 경우 {0} 개체를 역직렬화하는 것은 안전하지 않습니다. '{1}'은(는) {0}이거나 이 항목에서 파생됩니다.</target>
Expand Down
5 changes: 0 additions & 5 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.pl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,6 @@
<target state="translated">, </target>
<note>Separator used for separating list of platform names: {API} is only supported on: {‘windows’, ‘browser’, ‘linux’}</note>
</trans-unit>
<trans-unit id="CustomPreviewAPIMessage">
<source>'{0}'. '{1}'</source>
<target state="new">'{0}'. '{1}'</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInDeserializableObjectGraphMessage">
<source>When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}</source>
<target state="translated">Deserializowanie obiektu {0} podczas deserializacji niezaufanych danych wejściowych nie jest bezpieczne. Element „{1}” jest elementem {0} lub pochodzi od niego</target>
Expand Down
5 changes: 0 additions & 5 deletions ...alyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.pt-BR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,6 @@
<target state="translated">, </target>
<note>Separator used for separating list of platform names: {API} is only supported on: {‘windows’, ‘browser’, ‘linux’}</note>
</trans-unit>
<trans-unit id="CustomPreviewAPIMessage">
<source>'{0}'. '{1}'</source>
<target state="new">'{0}'. '{1}'</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInDeserializableObjectGraphMessage">
<source>When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}</source>
<target state="translated">Ao desserializar uma entrada não confiável, a desserialização de um objeto {0} não é segura. '{1}' é {0} ou deriva-se dele</target>
Expand Down
5 changes: 0 additions & 5 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.ru.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,6 @@
<target state="translated">, </target>
<note>Separator used for separating list of platform names: {API} is only supported on: {‘windows’, ‘browser’, ‘linux’}</note>
</trans-unit>
<trans-unit id="CustomPreviewAPIMessage">
<source>'{0}'. '{1}'</source>
<target state="new">'{0}'. '{1}'</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInDeserializableObjectGraphMessage">
<source>When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}</source>
<target state="translated">При десериализации недоверенных входных данных десериализация объекта {0} является небезопасной. Объект "{1}" является объектом {0} или производным от него объектом.</target>
Expand Down
5 changes: 0 additions & 5 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.tr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,6 @@
<target state="translated">, </target>
<note>Separator used for separating list of platform names: {API} is only supported on: {‘windows’, ‘browser’, ‘linux’}</note>
</trans-unit>
<trans-unit id="CustomPreviewAPIMessage">
<source>'{0}'. '{1}'</source>
<target state="new">'{0}'. '{1}'</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInDeserializableObjectGraphMessage">
<source>When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}</source>
<target state="translated">Güvenilmeyen giriş seri durumdan çıkarılırken, {0} nesnesinin seri durumdan çıkarılması güvenli değildir. '{1}', {0} nesnesidir veya bu nesneden türetilmiştir</target>
Expand Down
5 changes: 0 additions & 5 deletions ...yzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.zh-Hans.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,6 @@
<target state="translated">, </target>
<note>Separator used for separating list of platform names: {API} is only supported on: {‘windows’, ‘browser’, ‘linux’}</note>
</trans-unit>
<trans-unit id="CustomPreviewAPIMessage">
<source>'{0}'. '{1}'</source>
<target state="new">'{0}'. '{1}'</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInDeserializableObjectGraphMessage">
<source>When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}</source>
<target state="translated">对不受信任的输入进行反序列化处理时，反序列化 {0} 对象是不安全的。“{1}”是或派生自 {0}</target>
Expand Down
5 changes: 0 additions & 5 deletions ...yzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.zh-Hant.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,6 @@
<target state="translated">, </target>
<note>Separator used for separating list of platform names: {API} is only supported on: {‘windows’, ‘browser’, ‘linux’}</note>
</trans-unit>
<trans-unit id="CustomPreviewAPIMessage">
<source>'{0}'. '{1}'</source>
<target state="new">'{0}'. '{1}'</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInDeserializableObjectGraphMessage">
<source>When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}</source>
<target state="translated">還原序列化不受信任的輸入時，將 {0} 物件還原序列化並不安全。'{1}' 屬於或衍生自 {0}</target>
Expand Down
Loading