Skip to content

Support Url and Message parameters in RequiresPreviewFeaturesAttribute #5502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buyaa-n merged 26 commits into from
Oct 7, 2021
Merged

Support Url and Message parameters in RequiresPreviewFeaturesAttribute #5502

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
947927a
First cut of message and URL support. Needs to be cleaned up
Sep 16, 2021
0dac989
GeneralPreviewFeatureAttributeRule and unit test changes
Sep 17, 2021
1d70485
ImplementsPreviewInterfaceRule and unit test changes
Sep 17, 2021
e4105f9
UsesPreviewTypeParameterRule and unit test changes
Sep 17, 2021
4232a34
Everything else
Sep 17, 2021
3ec9901
Clean up
Sep 17, 2021
1732835
Fix test failures in PCA
buyaa-n Sep 20, 2021
06cd8cc
Self review + unit tests
Sep 20, 2021
1bc3edf
Make method static
Sep 21, 2021
712bfbc
First cut of addressing comments
Sep 23, 2021
5fefe10
Before reordering args
Sep 23, 2021
722716e
Checkpoint
Sep 23, 2021
eb77b71
All unit tests pass
Sep 24, 2021
f94f4b9
MInor cleanup
Sep 24, 2021
7e578a0
More cleanup
Sep 24, 2021
86bb96c
Before unit test regex changes
Sep 24, 2021
4eec26c
Bug fix and all unit tests pass
Sep 24, 2021
abbf59f
sq
Sep 24, 2021
969faa1
sq
Sep 24, 2021
7df6264
Address comments
Sep 28, 2021
98ee43d
sq
Sep 28, 2021
91aae98
pack
Sep 28, 2021
70151db
Merge conflicts
buyaa-n Oct 6, 2021
96db9b0
Omit quotes around urls in diagnostic messages
jeffhandley Oct 7, 2021
cd84f30
Formatting tweaks
jeffhandley Oct 7, 2021
4339b4a
Merge conflicts
buyaa-n Oct 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Everything else
  • Loading branch information
Prashanth Govindarajan committed Sep 17, 2021
commit 4232a348c40427ddd9ebea7c326c8a14d349a022
2 changes: 1 addition & 1 deletion src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1732,7 +1732,7 @@
<value>Converting an instance method to a static method may produce invalid code</value>
</data>
<data name="DerivesFromPreviewClassMessage" xml:space="preserve">
<value>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</value>
<value>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</value>
</data>
<data name="ImplementsPreviewInterfaceMessage" xml:space="preserve">
<value>'{0}' implements the preview interface '{1}' and therefore needs to opt into preview features.</value>
Expand Down
95 changes: 56 additions & 39 deletions src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/DetectPreviewFeatureAnalyzer.cs
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,8 @@
<note />
</trans-unit>
<trans-unit id="DerivesFromPreviewClassMessage">
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</target>
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</target>
<note />
</trans-unit>
<trans-unit id="DetectPreviewFeaturesDescription">
Expand Down
4 changes: 2 additions & 2 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,8 @@
<note />
</trans-unit>
<trans-unit id="DerivesFromPreviewClassMessage">
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</target>
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</target>
<note />
</trans-unit>
<trans-unit id="DetectPreviewFeaturesDescription">
Expand Down
4 changes: 2 additions & 2 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,8 @@
<note />
</trans-unit>
<trans-unit id="DerivesFromPreviewClassMessage">
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</target>
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</target>
<note />
</trans-unit>
<trans-unit id="DetectPreviewFeaturesDescription">
Expand Down
4 changes: 2 additions & 2 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,8 @@
<note />
</trans-unit>
<trans-unit id="DerivesFromPreviewClassMessage">
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</target>
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</target>
<note />
</trans-unit>
<trans-unit id="DetectPreviewFeaturesDescription">
Expand Down
4 changes: 2 additions & 2 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,8 @@
<note />
</trans-unit>
<trans-unit id="DerivesFromPreviewClassMessage">
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</target>
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</target>
<note />
</trans-unit>
<trans-unit id="DetectPreviewFeaturesDescription">
Expand Down
4 changes: 2 additions & 2 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.ja.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,8 @@
<note />
</trans-unit>
<trans-unit id="DerivesFromPreviewClassMessage">
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</target>
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</target>
<note />
</trans-unit>
<trans-unit id="DetectPreviewFeaturesDescription">
Expand Down
4 changes: 2 additions & 2 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.ko.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,8 @@
<note />
</trans-unit>
<trans-unit id="DerivesFromPreviewClassMessage">
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</target>
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</target>
<note />
</trans-unit>
<trans-unit id="DetectPreviewFeaturesDescription">
Expand Down
4 changes: 2 additions & 2 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.pl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,8 @@
<note />
</trans-unit>
<trans-unit id="DerivesFromPreviewClassMessage">
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</target>
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</target>
<note />
</trans-unit>
<trans-unit id="DetectPreviewFeaturesDescription">
Expand Down
4 changes: 2 additions & 2 deletions ...alyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.pt-BR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,8 @@
<note />
</trans-unit>
<trans-unit id="DerivesFromPreviewClassMessage">
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</target>
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</target>
<note />
</trans-unit>
<trans-unit id="DetectPreviewFeaturesDescription">
Expand Down
4 changes: 2 additions & 2 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.ru.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,8 @@
<note />
</trans-unit>
<trans-unit id="DerivesFromPreviewClassMessage">
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</target>
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</target>
<note />
</trans-unit>
<trans-unit id="DetectPreviewFeaturesDescription">
Expand Down
4 changes: 2 additions & 2 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.tr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,8 @@
<note />
</trans-unit>
<trans-unit id="DerivesFromPreviewClassMessage">
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</target>
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</target>
<note />
</trans-unit>
<trans-unit id="DetectPreviewFeaturesDescription">
Expand Down
4 changes: 2 additions & 2 deletions ...yzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.zh-Hans.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,8 @@
<note />
</trans-unit>
<trans-unit id="DerivesFromPreviewClassMessage">
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</target>
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</target>
<note />
</trans-unit>
<trans-unit id="DetectPreviewFeaturesDescription">
Expand Down
4 changes: 2 additions & 2 deletions ...yzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.zh-Hant.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,8 @@
<note />
</trans-unit>
<trans-unit id="DerivesFromPreviewClassMessage">
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information.</target>
<source>'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</source>
<target state="new">'{0}' derives from preview class '{1}' and therefore needs to opt into preview features.</target>
<note />
</trans-unit>
<trans-unit id="DetectPreviewFeaturesDescription">
Expand Down
Loading