Rework test cases

Add new warning for missing attribute from interface or base class

src/NetAnalyzers/CSharp/Microsoft.NetCore.Analyzers/Performance/CSharpConstantExpectedAnalyzer.cs

@@ -25,7 +25,6 @@ protected override void RegisterAttributeSyntax(CompilationStartAnalysisContext
         private void OnAttributeNode(SyntaxNodeAnalysisContext context)
         {
             var attributeSyntax = (AttributeSyntax)context.Node;
-            var sm = context.SemanticModel;
             if (!attributeSyntax.Name.IsEquivalentTo(_constantExpectedIdentifier) && !attributeSyntax.Name.IsEquivalentTo(_constantExpectedAttributeIdentifier))
             {
                 return;

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx

@@ -1870,6 +1870,9 @@
   <data name="ConstantExpectedAttributeOutOfBoundsMessage" xml:space="preserve">
     <value>The ConstantExpectedAttribute does not fit within the parameter value bounds of '{0}' to '{1}'.</value>
   </data>
+  <data name="ConstantExpectedAttributExpectedMessage" xml:space="preserve">
+    <value>The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</value>
+  </data>
   <data name="ConstantExpectedAttributeNotSameTypeMessage" xml:space="preserve">
     <value>The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</value>
   </data>

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Performance/ConstantExpectedAnalyzer.cs

@@ -104,6 +104,16 @@ public abstract partial class ConstantExpectedAnalyzer : DiagnosticAnalyzer
             isPortedFxCopRule: false,
             isDataflowRule: false);
 
+        internal static readonly DiagnosticDescriptor AttributeExpectedRule = DiagnosticDescriptorHelper.Create(
+            CA1861,
+            s_localizableUsageTitle,
+            CreateLocalizableResourceString(nameof(ConstantExpectedAttributExpectedMessage)),
+            DiagnosticCategory.Performance,
+            RuleLevel.BuildWarning,
+            description: s_localizableUsageDescription,
+            isPortedFxCopRule: false,
+            isDataflowRule: false);
+
         internal static readonly DiagnosticDescriptor AttributeNotSameTypeRule = DiagnosticDescriptorHelper.Create(
             CA1861,
             s_localizableUsageTitle,
@@ -115,7 +125,7 @@ public abstract partial class ConstantExpectedAnalyzer : DiagnosticAnalyzer
             isDataflowRule: false);
         public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; } = ImmutableArray.Create(
             InvalidTypeRule, IncompatibleConstantTypeRule, IncompatibleConstantForMinMaxRule, InvalidBoundsRule, InvertedRangeRule,
-            ConstantOutOfBoundsRule, ConstantNotConstantRule, AttributeOutOfBoundsRule, AttributeNotSameTypeRule);
+            ConstantOutOfBoundsRule, ConstantNotConstantRule, AttributeOutOfBoundsRule, AttributeExpectedRule, AttributeNotSameTypeRule);
 
         protected abstract DiagnosticHelper Helper { get; }
 
@@ -129,9 +139,40 @@ public override void Initialize(AnalysisContext context)
         private void OnCompilationStart(CompilationStartAnalysisContext context)
         {
             context.RegisterOperationAction(OnInvocation, OperationKind.Invocation);
+            context.RegisterSymbolAction(context => OnMethodSymbol(context), SymbolKind.Method);
             RegisterAttributeSyntax(context);
             return;
         }
+        private static void OnMethodSymbol(SymbolAnalysisContext context)
+        {
+            var methodSymbol = (IMethodSymbol)context.Symbol;
+            if (TryGetMethodInterface(methodSymbol, out var interfaceMethodSymbol))
+            {
+                CheckAttribute(context, methodSymbol.Parameters, interfaceMethodSymbol.Parameters);
+            }
+            else if (methodSymbol.OverriddenMethod is not null)
+            {
+                CheckAttribute(context, methodSymbol.Parameters, methodSymbol.OverriddenMethod.Parameters);
+            }
+
+            static void CheckAttribute(SymbolAnalysisContext context, ImmutableArray<IParameterSymbol> parameters, ImmutableArray<IParameterSymbol> baseParameters)
+            {
+                for (var i = 0; i < parameters.Length; i++)
+                {
+                    var parameter = parameters[i];
+                    if (!IsConstantCompatible(parameter.Type))
+                    {
+                        continue;
+                    }
+                    var baseParameter = baseParameters[i];
+                    if (HasConstantExpectedAttributeData(baseParameter) && !HasConstantExpectedAttributeData(parameter))
+                    {
+                        var diagnostic = parameter.DeclaringSyntaxReferences[0].GetSyntax().CreateDiagnostic(AttributeExpectedRule);
+                        context.ReportDiagnostic(diagnostic);
+                    }
+                }
+            }
+        }
 
         private static void OnInvocation(OperationAnalysisContext context)
         {
@@ -299,6 +340,12 @@ private static bool TryGetConstantExpectedAttributeData(IParameterSymbol paramet
             return constantExpectedAttributeData is not null;
         }
 
+        private static bool HasConstantExpectedAttributeData(IParameterSymbol parameter)
+        {
+            return parameter.GetAttributes()
+                .Any(attrData => IsConstantExpectedAttribute(attrData.AttributeClass));
+        }
+
         private static bool IsConstantExpectedAttribute(INamedTypeSymbol namedType)
         {
             return namedType.Name.Equals(ConstantExpectedAttribute, StringComparison.Ordinal) &&
@@ -396,6 +443,7 @@ public static (object? MinConstant, object? MaxConstant) GetAttributeConstants(A
             }
 
             return (minConstant, maxConstant);
+
             static object? ToObject(TypedConstant typedConstant)
             {
                 if (typedConstant.IsNull)
@@ -406,6 +454,59 @@ public static (object? MinConstant, object? MaxConstant) GetAttributeConstants(A
             }
         }
 
+        private static bool TryGetMethodInterface(IMethodSymbol methodSymbol, [NotNullWhen(true)] out IMethodSymbol? interfaceMethodSymbol)
+        {
+            var explicitInterface = methodSymbol.ExplicitInterfaceImplementations
+                .FirstOrDefault(exInterface => methodSymbol.IsImplementationOfInterfaceMember(exInterface));
+            if (explicitInterface is not null)
+            {
+                interfaceMethodSymbol = explicitInterface;
+                return true;
+            }
+
+            if (methodSymbol.ContainingType != null)
+            {
+                foreach (INamedTypeSymbol interfaceSymbol in methodSymbol.ContainingType.AllInterfaces)
+                {
+                    foreach (var interfaceMember in interfaceSymbol.GetMembers().OfType<IMethodSymbol>())
+                    {
+                        if (methodSymbol.IsImplementationOfInterfaceMember(interfaceMember))
+                        {
+                            interfaceMethodSymbol = interfaceMember;
+                            return true;
+                        }
+                    }
+                }
+            }
+
+            interfaceMethodSymbol = null;
+            return false;
+        }
+
+        private static bool IsConstantCompatible(ITypeSymbol type)
+        {
+            return type.SpecialType switch
+            {
+                SpecialType.System_Char => true,
+                SpecialType.System_Byte => true,
+                SpecialType.System_UInt16 => true,
+                SpecialType.System_UInt32 => true,
+                SpecialType.System_UInt64 => true,
+                SpecialType.System_UIntPtr => true,
+                SpecialType.System_SByte => true,
+                SpecialType.System_Int16 => true,
+                SpecialType.System_Int32 => true,
+                SpecialType.System_Int64 => true,
+                SpecialType.System_IntPtr => true,
+                SpecialType.System_Single => true,
+                SpecialType.System_Double => true,
+                SpecialType.System_Boolean => true,
+                SpecialType.System_String => true,
+                SpecialType.None when type.TypeKind == TypeKind.TypeParameter => true,
+                _ => false,
+            };
+        }
+
         protected abstract class DiagnosticHelper
         {
             public abstract Location? GetMinLocation(SyntaxNode attributeSyntax);

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.cs.xlf

@@ -192,6 +192,11 @@
         <target state="new">Incorrect use of ConstantExpectedAttribute</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConstantExpectedAttributExpectedMessage">
+        <source>The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</source>
+        <target state="new">The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ConstantExpectedAttributeNotSameTypeMessage">
         <source>The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</source>
         <target state="new">The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</target>

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.de.xlf

@@ -192,6 +192,11 @@
         <target state="new">Incorrect use of ConstantExpectedAttribute</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConstantExpectedAttributExpectedMessage">
+        <source>The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</source>
+        <target state="new">The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ConstantExpectedAttributeNotSameTypeMessage">
         <source>The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</source>
         <target state="new">The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</target>

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.es.xlf

@@ -192,6 +192,11 @@
         <target state="new">Incorrect use of ConstantExpectedAttribute</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConstantExpectedAttributExpectedMessage">
+        <source>The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</source>
+        <target state="new">The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ConstantExpectedAttributeNotSameTypeMessage">
         <source>The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</source>
         <target state="new">The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</target>

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.fr.xlf

@@ -192,6 +192,11 @@
         <target state="new">Incorrect use of ConstantExpectedAttribute</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConstantExpectedAttributExpectedMessage">
+        <source>The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</source>
+        <target state="new">The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ConstantExpectedAttributeNotSameTypeMessage">
         <source>The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</source>
         <target state="new">The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</target>

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.it.xlf

@@ -192,6 +192,11 @@
         <target state="new">Incorrect use of ConstantExpectedAttribute</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConstantExpectedAttributExpectedMessage">
+        <source>The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</source>
+        <target state="new">The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ConstantExpectedAttributeNotSameTypeMessage">
         <source>The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</source>
         <target state="new">The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</target>

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.ja.xlf

@@ -192,6 +192,11 @@
         <target state="new">Incorrect use of ConstantExpectedAttribute</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConstantExpectedAttributExpectedMessage">
+        <source>The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</source>
+        <target state="new">The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ConstantExpectedAttributeNotSameTypeMessage">
         <source>The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</source>
         <target state="new">The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</target>

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.ko.xlf

@@ -192,6 +192,11 @@
         <target state="new">Incorrect use of ConstantExpectedAttribute</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConstantExpectedAttributExpectedMessage">
+        <source>The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</source>
+        <target state="new">The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ConstantExpectedAttributeNotSameTypeMessage">
         <source>The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</source>
         <target state="new">The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</target>

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.pl.xlf

@@ -192,6 +192,11 @@
         <target state="new">Incorrect use of ConstantExpectedAttribute</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConstantExpectedAttributExpectedMessage">
+        <source>The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</source>
+        <target state="new">The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ConstantExpectedAttributeNotSameTypeMessage">
         <source>The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</source>
         <target state="new">The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</target>

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.pt-BR.xlf

@@ -192,6 +192,11 @@
         <target state="new">Incorrect use of ConstantExpectedAttribute</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConstantExpectedAttributExpectedMessage">
+        <source>The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</source>
+        <target state="new">The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ConstantExpectedAttributeNotSameTypeMessage">
         <source>The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</source>
         <target state="new">The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</target>

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.ru.xlf

@@ -192,6 +192,11 @@
         <target state="new">Incorrect use of ConstantExpectedAttribute</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConstantExpectedAttributExpectedMessage">
+        <source>The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</source>
+        <target state="new">The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ConstantExpectedAttributeNotSameTypeMessage">
         <source>The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</source>
         <target state="new">The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</target>

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.tr.xlf

@@ -192,6 +192,11 @@
         <target state="new">Incorrect use of ConstantExpectedAttribute</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConstantExpectedAttributExpectedMessage">
+        <source>The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</source>
+        <target state="new">The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ConstantExpectedAttributeNotSameTypeMessage">
         <source>The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</source>
         <target state="new">The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</target>

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.zh-Hans.xlf

@@ -192,6 +192,11 @@
         <target state="new">Incorrect use of ConstantExpectedAttribute</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConstantExpectedAttributExpectedMessage">
+        <source>The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</source>
+        <target state="new">The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ConstantExpectedAttributeNotSameTypeMessage">
         <source>The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</source>
         <target state="new">The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</target>

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.zh-Hant.xlf

@@ -192,6 +192,11 @@
         <target state="new">Incorrect use of ConstantExpectedAttribute</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConstantExpectedAttributExpectedMessage">
+        <source>The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</source>
+        <target state="new">The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ConstantExpectedAttributeNotSameTypeMessage">
         <source>The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</source>
         <target state="new">The ConstantExpectedAttribute does not have the same '{0}' type as the ConstantExpectedAttribute in the invoked method parameter.</target>