Apply suggestions from code review

Co-authored-by: Robin Lindner <robin@deeprobin.de>

src/NetAnalyzers/CSharp/Microsoft.NetCore.Analyzers/Performance/CSharpConstantExpectedAnalyzer.cs

@@ -22,10 +22,12 @@ protected override void RegisterAttributeSyntax(CompilationStartAnalysisContext
         {
             context.RegisterSyntaxNodeAction(context => OnAttributeNode(context), SyntaxKind.Attribute);
         }
+
         private void OnAttributeNode(SyntaxNodeAnalysisContext context)
         {
             var attributeSyntax = (AttributeSyntax)context.Node;
-            if (!attributeSyntax.Name.IsEquivalentTo(s_constantExpectedIdentifier) && !attributeSyntax.Name.IsEquivalentTo(s_constantExpectedAttributeIdentifier))
+            var attributeName = attributeSyntax.Name;
+            if (!attributeName.IsEquivalentTo(s_constantExpectedIdentifier) && !attributeName.IsEquivalentTo(s_constantExpectedAttributeIdentifier))
             {
                 return;
             }

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx

@@ -1865,13 +1865,13 @@
     <value>'{0}' uses the preview type '{1}' and needs to opt into preview features. See {2} for more information.</value>
   </data>
   <data name="ConstantExpectedApplicationTitle" xml:space="preserve">
-    <value>Incorrect use of ConstantExpectedAttribute</value>
+    <value>Incorrect usage of ConstantExpected attribute</value>
   </data>
   <data name="ConstantExpectedApplicationDescription" xml:space="preserve">
-    <value>ConstantExpectedAttribute is not applied correctly on the paramter.</value>
+    <value>ConstantExpectedAttribute is not applied correctly on the parameter.</value>
   </data>
   <data name="ConstantExpectedUsageTitle" xml:space="preserve">
-    <value>Constant is expected for the parameter</value>
+    <value>A constant is expected for the parameter</value>
   </data>
   <data name="ConstantExpectedUsageDescription" xml:space="preserve">
     <value>The parameter expects a constant for optimal performance.</value>
@@ -1886,13 +1886,13 @@
     <value>The '{0}' value does not fit within the parameter value bounds of '{1}' to '{2}'.</value>
   </data>
   <data name="ConstantExpectedInvertedRangeMessage" xml:space="preserve">
-    <value>The Min and Max value are inverted.</value>
+    <value>The Min and Max values are inverted.</value>
   </data>
   <data name="ConstantExpectedOutOfBoundsMessage" xml:space="preserve">
     <value>The constant does not fit within the value bounds of '{0}' to '{1}'.</value>
   </data>
   <data name="ConstantExpectedInvalidMessage" xml:space="preserve">
-    <value>The constant is not of the same '{0}' type as the parameter</value>
+    <value>The constant is not of the same '{0}' type as the parameter.</value>
   </data>
   <data name="ConstantExpectedNotConstantMessage" xml:space="preserve">
     <value>The argument should be a constant for optimal performance.</value>

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Performance/ConstantExpectedAnalyzer.cs

@@ -132,7 +132,6 @@ private void OnCompilationStart(CompilationStartAnalysisContext context)
             context.RegisterOperationAction(OnInvocation, OperationKind.Invocation);
             context.RegisterSymbolAction(context => OnMethodSymbol(context), SymbolKind.Method);
             RegisterAttributeSyntax(context);
-            return;
         }
 
         private static void OnMethodSymbol(SymbolAnalysisContext context)

src/NetAnalyzers/UnitTests/Microsoft.NetCore.Analyzers/Performance/ConstantExpectedTests.cs

@@ -8,7 +8,7 @@
     Microsoft.NetCore.CSharp.Analyzers.Performance.CSharpConstantExpectedAnalyzer,
     Microsoft.CodeAnalysis.Testing.EmptyCodeFixProvider>;
 
-namespace Microsoft.CodeAnalysis.NetAnalyzers.UnitTests.Microsoft.NetCore.Analyzers.Performance
+namespace Microsoft.NetCore.Analyzers.Performance.UnitTests
 {
     public sealed class ConstantExpectedTests
     {
@@ -528,7 +528,7 @@ public static void TestMethod()
     {{
         TestMethodWithConstant({{|#0:{testValue}|}});
     }}
-    public static void TestMethodWithConstant([ConstantExpected(Min={min}, Max={max})] {type} val) {{ }}
+    public static void TestMethodWithConstant([ConstantExpected(Min = {min}, Max = {max})] {type} val) {{ }}
 }}
 ";
             await TestCSAsync(csInput,