Merge dev15.7.x to dev15.7.x-vs-deps #24665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lock is only being used to protect access to an instance which contains internal synchronization.
Roslyn is designed to have the simplest possible contribution story: clone then build. Every pre-req needed is either located on the machine or bootstrapped via NuGet. All the way down to using an xcopy MSBuild if needed. The one case which causes a problem is the VS command prompt. In this case MSBuild is pre-installed on the machine and may or may not be suitable for building Roslyn. Previously when building from a VS command prompt we just used whatever MSBuild was provided. The assumption being a developer command prompt was an explicit statement of whath MSBuild you wanted to use. Based on all of our customer reports though this does not seem to be the assumption that consumers of our repo have. The build gave them no explicit errors about the provided toolset and hence when the build failed they assigned flakiness to our repo. Going forward we are applying the same version validation to MSBuild when provided via a developer command prompt. If it doesn't match we will refuse to build asking the user to upgrade VS or build from a normal command prompt.
Better handle surrounding directives when inlining a local variable.
Support negative null-checks when we offer a fix to use pattern-matching
#24458) * fix a case where persistent storage registration fails and some clean up code around it. * added readonly * address PR feedback * removed comments no longer relevant * renamed lock name
Fix and re-enable test that would catch this error
Verify MSBuild version in Developer CMD prompt
Move to xunit.console for CoreClr tests
Reduce allocations in UnboundLambda
* Check fully-qualified names for SuppressIldasmAttribute and ReferenceAssemblyAttribute * Use correct reference location, or fail decompilation if it's not available
Fix command line build error
Update optimization data to 2.7.0-beta3-62526-01...
Locate implementations for reference assemblies using the GAC
…0180205-080009 Merge dev15.6.x to dev15.7.x
Port fix for duplicate IDEDiagnosticIDs to 15.7
…0180206-080012 Merge dev15.6.x to dev15.7.x
Contributor
|
@dotnet-bot retest windows_debug_unit32_prtest please. |
heejaechang
approved these changes
Feb 7, 2018
AbhitejJohn
deleted the
merges/dev15.7.x-to-dev15.7.x-vs-deps-20180206-080026
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from dev15.7.x into dev15.7.x-vs-deps.
git fetch --all git checkout merges/dev15.7.x-to-dev15.7.x-vs-deps-20180206-080026 git reset --hard upstream/dev15.7.x-vs-deps git merge upstream/dev15.7.x # Fix merge conflicts git commit git push merges/dev15.7.x-to-dev15.7.x-vs-deps-20180206-080026 --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.