Merge dev15.7.x to dev15.7.x-vs-deps #24637
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lock is only being used to protect access to an instance which contains internal synchronization.
Roslyn is designed to have the simplest possible contribution story: clone then build. Every pre-req needed is either located on the machine or bootstrapped via NuGet. All the way down to using an xcopy MSBuild if needed. The one case which causes a problem is the VS command prompt. In this case MSBuild is pre-installed on the machine and may or may not be suitable for building Roslyn. Previously when building from a VS command prompt we just used whatever MSBuild was provided. The assumption being a developer command prompt was an explicit statement of whath MSBuild you wanted to use. Based on all of our customer reports though this does not seem to be the assumption that consumers of our repo have. The build gave them no explicit errors about the provided toolset and hence when the build failed they assigned flakiness to our repo. Going forward we are applying the same version validation to MSBuild when provided via a developer command prompt. If it doesn't match we will refuse to build asking the user to upgrade VS or build from a normal command prompt.
Better handle surrounding directives when inlining a local variable.
Support negative null-checks when we offer a fix to use pattern-matching
#24458) * fix a case where persistent storage registration fails and some clean up code around it. * added readonly * address PR feedback * removed comments no longer relevant * renamed lock name
It turns out we had some tests, but the tests were disabled. This was because the tests weren't working properly anyways: they were calling into UpdateProjectBinPath which only updated some (but not all) of the project state. That was an internal helper method that shouldn't be used by tests. Updating the tests to use SetBinOutputPathAndRelatedData works better.
This was some legacy code that tried to verify that the references we have from the project system match up to what DTE and other sources say. This was debug-only, and the actual asserts were commented out. This is deadweight at this point, so delete it.
also added RoslynActivityLogger that can be enabled through project-system-tool
Remove duplicate lock DocumentState.s_syntaxTreeToIdMapLock
…0180201-080013 Merge dev15.6.x to dev15.7.x
…-code Cleanup project system code
Omit Default modifier style & code fix
CS1628 error text mentions in parameters; fixes #24584
Small cleanup of completion logic.
Previously we were using xunit.console for desktop tests and dotnet-xunit for our CoreClr tests. This change unifies us on top of xunit.console (now that it has a netcoreapp2.0 version available).
Verify MSBuild version in Developer CMD prompt
Move to xunit.console for CoreClr tests
Reduce allocations in UnboundLambda
…s-deps-20180205-080023
AbhitejJohn
approved these changes
Feb 5, 2018
Contributor
|
@heejaechang : There just seem to be a chain of merge issues after this PR. Tried to fix a few but that seems to lead to others. Can you take a look please. |
Contributor
|
Abandoning this in favour of #24665. |
AbhitejJohn
deleted the
merges/dev15.7.x-to-dev15.7.x-vs-deps-20180205-080023
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from dev15.7.x into dev15.7.x-vs-deps.
git fetch --all git checkout merges/dev15.7.x-to-dev15.7.x-vs-deps-20180205-080023 git reset --hard upstream/dev15.7.x-vs-deps git merge upstream/dev15.7.x # Fix merge conflicts git commit git push merges/dev15.7.x-to-dev15.7.x-vs-deps-20180205-080023 --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.