Skip to content

JIT: Add basic support for Swift reverse pinvokes #100018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakobbotsch merged 16 commits into from
Mar 21, 2024
Merged

JIT: Add basic support for Swift reverse pinvokes #100018

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
9a9a052
Add test
jakobbotsch Mar 19, 2024
bfd4e28
Support SwiftSelf
jakobbotsch Mar 20, 2024
53d00a6
Backend handling
jakobbotsch Mar 20, 2024
ea5c172
Fix arm64 build
jakobbotsch Mar 20, 2024
4fd5964
Add missing handling of DNER reason
jakobbotsch Mar 20, 2024
ea32187
Fix assert
jakobbotsch Mar 20, 2024
e01d190
Fix build
jakobbotsch Mar 20, 2024
40d998a
Remove some unnecessarily aggressive asserts
jakobbotsch Mar 20, 2024
4c64049
Expand assert
jakobbotsch Mar 20, 2024
7d43f3c
Reduce tests
jakobbotsch Mar 20, 2024
49826a8
Disable tests on Mono
jakobbotsch Mar 20, 2024
d65c4c3
Regenerate tests
jakobbotsch Mar 20, 2024
3e76803
Factor int parameter register validation
jakobbotsch Mar 21, 2024
21d1c52
Add missing license headers
jakobbotsch Mar 21, 2024
b4b73d7
More feedback
jakobbotsch Mar 21, 2024
cb44f0b
Run jit-format
jakobbotsch Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove some unnecessarily aggressive asserts
  • Loading branch information
@jakobbotsch
jakobbotsch committed Mar 20, 2024
commit 40d998ace1c7377b89579e5ad47ec86f3b7a9f96
9 changes: 0 additions & 9 deletions src/coreclr/jit/scopeinfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1721,8 +1721,6 @@ void CodeGen::psiBegProlog()
regNumber otherRegNum = REG_NA;
for (unsigned nCnt = 0; nCnt < structDesc.eightByteCount; nCnt++)
{
var_types regType = TYP_UNDEF;

if (nCnt == 0)
{
regNum = lclVarDsc->GetArgReg();
Expand All @@ -1735,12 +1733,6 @@ void CodeGen::psiBegProlog()
{
assert(false && "Invalid eightbyte number.");
}

regType = compiler->GetEightByteType(structDesc, nCnt);
#ifdef DEBUG
regType = compiler->mangleVarArgsType(regType);
assert(genMapRegNumToRegArgNum((nCnt == 0 ? regNum : otherRegNum), regType) != (unsigned)-1);
#endif // DEBUG
Comment on lines -1738 to -1743
Copy link
Member Author

@jakobbotsch jakobbotsch Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed this assert in a couple of places because I don't think it is asserting anything meaningful. The existence and mapping of genMapRegNumToRegArgNum is really an internal detail of how genFnPrologCalleeRegArgs works, and I expect to be able to remove it once that function is rewritten.

}

varLocation.storeVariableInRegisters(regNum, otherRegNum);
Expand Down Expand Up @@ -1789,7 +1781,6 @@ void CodeGen::psiBegProlog()
regType = lclVarDsc->GetHfaType();
}
#endif // defined(TARGET_LOONGARCH64) || defined(TARGET_RISCV64)
assert(genMapRegNumToRegArgNum(lclVarDsc->GetArgReg(), regType) != (unsigned)-1);
#endif // DEBUG
varLocation.storeVariableInRegisters(lclVarDsc->GetArgReg(), REG_NA);
}
Expand Down