Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@

namespace ILCompiler.Logging
{

public sealed partial class DocumentationSignatureGenerator
internal sealed partial class DocumentationSignatureGenerator
{
/// <summary>
/// A visitor that generates the part of the documentation comment after the initial type
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,14 @@
<ProjectReference Include="../ILCompiler.RyuJit/ILCompiler.RyuJit.csproj" />
</ItemGroup>

<ItemGroup>
<Compile Include="$(ToolsProjectRoot)illink/src/linker/Linker/TypeNameResolver.cs" />
<Compile Include="$(ToolsProjectRoot)illink/src/linker/Linker/ITryResolve.cs" />
<Compile Include="$(ToolsProjectRoot)illink/src/linker/Linker/ModuleDefinitionExtensions.cs" />
<Compile Include="$(LibrariesProjectRoot)/Common/src/System/Reflection/Metadata/TypeNameHelpers.cs" />
<Compile Include="$(LibrariesProjectRoot)/Common/src/System/Text/ValueStringBuilder.cs" />
</ItemGroup>

<ItemGroup>
<RuntimeHostConfigurationOption Include="Mono.Linker.Tests.RuntimeBinDirectory">
<Value>$(RuntimeBinDir)</Value>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ class LinkedMethodEntity : LinkedEntity
}

private readonly BaseAssemblyResolver originalsResolver;
private readonly TypeNameResolver originalsTypeNameResolver;
private readonly ReaderParameters originalReaderParameters;
private readonly AssemblyDefinition originalAssembly;
private readonly TrimmedTestCaseResult testResult;
Expand Down Expand Up @@ -69,6 +70,7 @@ public AssemblyChecker (
TrimmedTestCaseResult testResult)
{
this.originalsResolver = originalsResolver;
this.originalsTypeNameResolver = new TypeNameResolver (new TestResolver (), new TestAssemblyNameResolver (originalsResolver));
this.originalReaderParameters = originalReaderParameters;
this.originalAssembly = original;
this.testResult = testResult;
Expand Down Expand Up @@ -1468,7 +1470,9 @@ internal IEnumerable<string> VerifyLinkingOfOtherAssemblies (AssemblyDefinition
}

var expectedTypeName = checkAttrInAssembly.ConstructorArguments[1].Value.ToString ()!;
var expectedType = originalTargetAssembly.MainModule.GetType(expectedTypeName);
if (!originalsTypeNameResolver.TryResolveTypeName (originalTargetAssembly, expectedTypeName, out TypeReference? expectedTypeRef, out _))
Assert.Fail($"Could not resolve original type `{expectedTypeName}' in assembly {assemblyName}");
TypeDefinition expectedType = expectedTypeRef.Resolve ();
Comment on lines +1473 to +1475
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Append to the errs list rather than failing immediately.

Suggested change
if (!originalsTypeNameResolver.TryResolveTypeName (originalTargetAssembly, expectedTypeName, out TypeReference? expectedTypeRef, out _))
Assert.Fail($"Could not resolve original type `{expectedTypeName}' in assembly {assemblyName}");
TypeDefinition expectedType = expectedTypeRef.Resolve ();
if (!originalsTypeNameResolver.TryResolveTypeName (originalTargetAssembly, expectedTypeName, out TypeReference? expectedTypeRef, out _)) {
errs.Add($"Could not resolve original type `{expectedTypeName}' in assembly {assemblyName}");
continue;
}
TypeDefinition expectedType = expectedTypeRef.Resolve ();

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather keep this one as an assert because it indicates a test authoring issue, and this matches what we do in some other places that fail to resolve something from the input.

linkedMembersInAssembly.TryGetValue(new AssemblyQualifiedToken(expectedType), out LinkedEntity? linkedTypeEntity);
MetadataType? linkedType = linkedTypeEntity?.Entity as MetadataType;

Expand Down
1 change: 0 additions & 1 deletion src/tools/illink/external/corert/README.md

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading