JIT: Zero continuation return after profiler leave callback #122490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a JIT codegen issue where the async continuation return register was zeroed too early, before the profiler leave callback was invoked. This caused incorrect behavior when async methods with profiler instrumentation returned normally (non-suspending returns).
Key Changes
- Move the zeroing of
REG_ASYNC_CONTINUATION_RETto occur after the profiler leave callback ingenReturn - Add explicit GC tracking calls (
gcMarkRegPtrVal) at the points where the async continuation register state changes - Remove the centralized GC marking for the async continuation register from
genMarkReturnGCInfo
This was referenced Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#122195 introduced a runtime async test that is the first one to run in combination with other stress configurations. It revealed that when leave callbacks are emitted we do not appropriately zero the async continuation on standard returns.
Fix #122475