Skip to content

JIT: Zero continuation return after profiler leave callback #122490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakobbotsch wants to merge 3 commits into
base: main
Choose a base branch
from
Open

JIT: Zero continuation return after profiler leave callback #122490

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e208c46
JIT: Zero continuation return after profiler leave callback
jakobbotsch Dec 12, 2025
4240d32
Fix
jakobbotsch Dec 12, 2025
5dcf35e
Nit
jakobbotsch Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions src/coreclr/jit/codegencommon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7069,11 +7069,6 @@ void CodeGen::genReturn(GenTree* treeNode)
}
}

if (treeNode->OperIs(GT_RETURN) && compiler->compIsAsync())
{
instGen_Set_Reg_To_Zero(EA_PTRSIZE, REG_ASYNC_CONTINUATION_RET);
}

#if EMIT_GENERATE_GCINFO
if (treeNode->OperIs(GT_RETURN, GT_SWIFT_ERROR_RET))
{
Expand All @@ -7097,6 +7092,12 @@ void CodeGen::genReturn(GenTree* treeNode)
}
#endif // PROFILING_SUPPORTED

if (treeNode->OperIs(GT_RETURN) && compiler->compIsAsync())
{
instGen_Set_Reg_To_Zero(EA_PTRSIZE, REG_ASYNC_CONTINUATION_RET);
gcInfo.gcMarkRegPtrVal(REG_ASYNC_CONTINUATION_RET, TYP_REF);
}

#if defined(DEBUG) && defined(TARGET_XARCH)
bool doStackPointerCheck = compiler->opts.compStackCheckOnRet;

Expand Down Expand Up @@ -7160,6 +7161,7 @@ void CodeGen::genReturnSuspend(GenTreeUnOp* treeNode)

regNumber reg = genConsumeReg(op);
inst_Mov(TYP_REF, REG_ASYNC_CONTINUATION_RET, reg, /* canSkip */ true);
gcInfo.gcMarkRegPtrVal(REG_ASYNC_CONTINUATION_RET, TYP_REF);

ReturnTypeDesc retTypeDesc = compiler->compRetTypeDesc;
unsigned numRetRegs = retTypeDesc.GetReturnRegCount();
Expand Down Expand Up @@ -7196,11 +7198,6 @@ void CodeGen::genMarkReturnGCInfo()
retTypeDesc.GetReturnRegType(i));
}
}

if (compiler->compIsAsync())
{
gcInfo.gcMarkRegPtrVal(REG_ASYNC_CONTINUATION_RET, TYP_REF);
}
}

//------------------------------------------------------------------------
Expand Down
Loading