Skip to content

Add test coverage for Task/ValueTask-returning methods with __arglist #122500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add test coverage for Task/ValueTask-returning methods with __arglist #122500

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
534ace8
Initial plan
Copilot Dec 12, 2025
0ad1c55
Add varargs async test with Task and ValueTask<int>
Copilot Dec 12, 2025
5dcf8df
Change methods to return completed Task/ValueTask instead of async
Copilot Dec 12, 2025
5a0b6c6
Enable async feature/tests
VSadov Oct 18, 2025
835bb64
handle vararg menthods that are not MethodReturnKind::NormalMethod
VSadov Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
handle vararg menthods that are not MethodReturnKind::NormalMethod
  • Loading branch information
@VSadov
VSadov committed Dec 13, 2025
commit 835bb64d9d43878097bc54e68e122b7897cc07a0
17 changes: 17 additions & 0 deletions src/coreclr/vm/methodtablebuilder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3301,6 +3301,23 @@ MethodTableBuilder::EnumerateClassMethods()
}
}

// Vararg methods are not allowed to be marked MethodImpl.Async
// and even when they return Tasks they are still treated as NormalMethod.
if (returnKind != MethodReturnKind::NormalMethod)
{
if (MetaSig::IsVarArg(Signature(pMemberSignature, cMemberSignature)))
{
if (IsMiAsync(dwImplFlags))
{
BuildMethodTableThrowException(IDS_EE_VARARG_NOT_SUPPORTED);
}
else
{
returnKind = MethodReturnKind::NormalMethod;
}
}
}

//
// Create a new bmtMDMethod representing this method and add it to the
// declared method list.
Expand Down
Loading