pass Span through Windows PAL #32008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfurt
added
enhancement
stephentoub
reviewed
Feb 10, 2020
src/libraries/Common/src/Interop/Windows/SspiCli/SecuritySafeHandles.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Feb 10, 2020
src/libraries/Common/src/Interop/Windows/SspiCli/SecuritySafeHandles.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Feb 10, 2020
src/libraries/Common/src/System/Net/Security/SecurityBuffer.Windows.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Feb 10, 2020
jkotas
approved these changes
Feb 10, 2020
jkotas
reviewed
Feb 10, 2020
src/libraries/Common/src/Interop/Windows/SspiCli/SecuritySafeHandles.cs
Outdated
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fragment of deprecated #1949.
With #453, we start using Span inside of SslStream.
However, it was not easy to pass it all the way to native calls using ArraySegment.
Also Windows.PAL is the only platform using ArraySegment.
This is not functional change.
The sole purpose is the ability to pass Span from SslStream and make all three PAL implementations more consistent.
Since Span is ref struct, we need ref struct wrapper to pass it through the layers.
There will be more change to SslStream itself but this PR raves out changes to Windows PAL.