fix regression in ChannelBinding/NTLM auth #40222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl |
geoffkizer
reviewed
Aug 3, 2020
src/libraries/Common/src/Interop/Windows/SspiCli/SecuritySafeHandles.cs
Outdated
Show resolved
Hide resolved
Contributor
|
Aside from that, LGTM |
geoffkizer
approved these changes
Aug 3, 2020
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
* fix regression in ChannelBinding/NTLM auth * fix index
This was referenced Aug 13, 2020
This was referenced Aug 25, 2020
Contributor
|
@wfurt can you confirm if this change is already in .NET 5 preview 8? |
Member
Author
|
It does not seems to @SteveL-MSFT. Looks like the fix missed the train and I don't see it in preview8 branch. |
Contributor
|
@wfurt thanks for the confirmation. The reported issues in the PowerShell web cmdlets repro'd with a build with .NET 5 preview 8 and was concerned that this PR didn't fix it. Looks like I'll have to see if it's fixed with RC1. |
Member
Author
|
unfortunately, yes. You can always grab daily build if you have local repro outside of production. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regression caused by #32008. The old security buffer had dedicated size property. With the PR, we switched to using Span and Span.Length. However that is not correct for TokenBinding. For that the span is empty e.g.
cbBufferbecomes 0 and OS will reject ChannelBinding buffer.Alternatively we can convert the UnmanagedToken to Span as well. But since currently doing not have any good test infrastructure for this, I would prefer to limit the changes.
This effectively solves #39011 but I will leave it open until we have tests to prevent regression like this.
contributes to #39011.