Skip to content

Fix failing Sockets tests after argument exception changes #36645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 1 commit into from
May 18, 2020
+4 −4
Merged

Fix failing Sockets tests after argument exception changes #36645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libraries/System.Net.Sockets/tests/FunctionalTests/DualModeSocketTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1649,7 +1649,7 @@ public void Socket_ReceiveFromAsyncV4IPEndPointFromV4Client_Throws()
args.RemoteEndPoint = new IPEndPoint(IPAddress.Loopback, UnusedPort);
args.SetBuffer(new byte[1], 0, 1);

AssertExtensions.Throws<ArgumentException>("RemoteEndPoint", () =>
AssertExtensions.Throws<ArgumentException>("e", () =>
{
socket.ReceiveFromAsync(args);
});
Expand Down Expand Up @@ -2188,7 +2188,7 @@ public void Socket_ReceiveMessageFromAsyncV4IPEndPointFromV4Client_Throws()
args.RemoteEndPoint = new IPEndPoint(IPAddress.Loopback, UnusedPort);
args.SetBuffer(new byte[1], 0, 1);

AssertExtensions.Throws<ArgumentException>("RemoteEndPoint", () =>
AssertExtensions.Throws<ArgumentException>("e", () =>
{
socket.ReceiveMessageFromAsync(args);
});
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Net.Sockets/tests/FunctionalTests/LingerStateTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ private void TestLingerState_Success(Socket sock, bool enabled, int lingerTime)

private void TestLingerState_ArgumentException(Socket sock, bool enabled, int lingerTime)
{
AssertExtensions.Throws<ArgumentException>("optionValue.LingerTime", () =>
AssertExtensions.Throws<ArgumentException>("optionValue", () =>
{
sock.LingerState = new LingerOption(enabled, lingerTime);
});
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Net.Sockets/tests/FunctionalTests/SendPacketsAsync.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ public void NotConnected_Throw()
[InlineData(SocketImplementationType.Async)]
public void NullList_Throws(SocketImplementationType type)
{
AssertExtensions.Throws<ArgumentNullException>("e.SendPacketsElements", () => SendPackets(type, (SendPacketsElement[])null, SocketError.Success, 0));
AssertExtensions.Throws<ArgumentException>("e", () => SendPackets(type, (SendPacketsElement[])null, SocketError.Success, 0));
}

[OuterLoop]
Expand Down