Delete suspicious code in RuntimeType

[MichalStrehovsky]

This code indicates that we can somehow get to fields on interfaces by reflecting on fields of a type implementing the interface. If that's the case, we have work to do in IL Linker. But I have not been able to find a way to do that, mostly because static fields don't get inherited the same as instance fields and we don't allow instance fields on interfaces.

Deleting the code to see if we have any failing tests.

[MichalStrehovsky]

/azp run runtime-libraries-coreclr outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[MichalStrehovsky]

/azp run runtime-coreclr outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jkotas]

using System;
using System.Reflection;

interface IFace
{
    public static int x = 0;
}

class Program : IFace
{
    static void Main(string[] args)
    {
        foreach (var f in typeof(Program).GetFields(BindingFlags.Public | BindingFlags.Static | BindingFlags.FlattenHierarchy)) Console.WriteLine(f);
    }
}

[MichalStrehovsky]

jkotas commented 3 hours ago

Heh, thanks! Looks like we have no test coverage for it.

Good thing it's consistent with how we do methods (not).

@vitek-karas looks like we'll have a linker issue after all. It looks like a pretty annoying one. We might want to just consider won't fixing it (and leave some traces on that decision)