Skip to content

Delete suspicious code in RuntimeType #52535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MichalStrehovsky wants to merge 2 commits into from
+0 −28
Closed

Delete suspicious code in RuntimeType #52535

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6683974
Delete suspicious code in RuntimeType
MichalStrehovsky May 10, 2021
5f681dc
Update RuntimeType.CoreCLR.cs
MichalStrehovsky May 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,34 +823,6 @@ private RuntimeFieldInfo[] PopulateFields(Filter filter)
}
#endregion

#region Populate Literal Fields on Interfaces
if (ReflectedType.IsGenericParameter)
{
Type[] interfaces = ReflectedType.BaseType!.GetInterfaces();

for (int i = 0; i < interfaces.Length; i++)
{
// Populate literal fields defined on any of the interfaces implemented by the declaring type
PopulateLiteralFields(filter, (RuntimeType)interfaces[i], ref list);
PopulateRtFields(filter, (RuntimeType)interfaces[i], ref list);
}
}
else
{
Type[]? interfaces = RuntimeTypeHandle.GetInterfaces(ReflectedType);

if (interfaces != null)
{
for (int i = 0; i < interfaces.Length; i++)
{
// Populate literal fields defined on any of the interfaces implemented by the declaring type
PopulateLiteralFields(filter, (RuntimeType)interfaces[i], ref list);
PopulateRtFields(filter, (RuntimeType)interfaces[i], ref list);
}
}
}
#endregion

return list.ToArray();
}

Expand Down