Skip to content

Add symbolic link APIs #54253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsitnik merged 51 commits into from
Jul 9, 2021
Merged

Add symbolic link APIs #54253

Changes from 1 commit
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
b63c7b7
ref declarations and src empty definitions
carlossanlop Jun 1, 2021
b223304
Implementation for Unix symlinks APIs and cross-platform unit tests.
carlossanlop Jun 1, 2021
2e822fd
Add windows implementation of [sym]link APIs
jozkee Jun 11, 2021
32e196c
Use ValueStringBuilder in ResolveLinkTarget
carlossanlop Jun 15, 2021
8ed2772
Build failure in FileSystemWatcher csproj due to missing new interop …
carlossanlop Jun 17, 2021
abbecf0
Fix build failure. Address documentation suggestions.
Jun 17, 2021
fc49855
Add missing csproj references to System.Net.Ping.Functional.Tests (pr…
carlossanlop Jun 18, 2021
86cbd19
Move CanCreateSymbolicLinks from FileSystemWatcher one class above, s…
Jun 18, 2021
480d3df
Fix some Microsoft.IO.Redist CI failures.
carlossanlop Jun 18, 2021
a6cd9da
Fix CI build failures from Net5Compat.Tests
carlossanlop Jun 18, 2021
6952eb7
Clean CanCreateSymbolicLinks for readability. Remove incomplete code.
carlossanlop Jun 21, 2021
797ace5
Support long paths in GetFinalPathNameByHandle
jozkee Jun 18, 2021
8639e3b
Use MS.IO.Redist friendly APIs for marshalling
jozkee Jun 19, 2021
6bb1aa9
Add IsBrowser check to CanCreateSymbolicLinks
carlossanlop Jun 21, 2021
88bcadb
Add more tests and fix some issues in windows
jozkee Jun 22, 2021
8701118
Add path to IO_InconsistentLinkType exception msg
carlossanlop Jun 22, 2021
d10e00c
Fix failure in test creating inconsistent file/dir type.
carlossanlop Jun 22, 2021
fa5ff40
Fix net48 error
jozkee Jun 22, 2021
6788db7
Address CreateSymbolicLink initial check on Unix to verify pathToTarg…
Jun 22, 2021
45392b4
Use RemoteExecutor for a test related to change the current working dir
jozkee Jun 23, 2021
38b6e88
Add missing argument to exception message in MS.IO.Redist
Jun 23, 2021
a70cdef
nit: Clean comment on CreateSymbolicLink p/invoke.
Jun 23, 2021
cbcf7af
Fix CI bug in Windows Nano where %TEMP% points to "C:\Windows\TEMP" b…
carlossanlop Jun 26, 2021
c43664a
Use ALLOW_UNPRIVILEGED_CREATE only on windows versions >= 10.0.14972
jozkee Jun 26, 2021
9460264
Do not use IsWindowsVersionAtLeast since isn't avail in ns2.0
jozkee Jun 28, 2021
bbaa35a
Use PrintName (Dos) instead of SubstituteName (NT)
jozkee Jun 28, 2021
7e2eaa9
Fix issues related to server share paths
jozkee Jun 29, 2021
0d4250b
Fix CI issues
jozkee Jun 29, 2021
1a05a56
Address suggestions
jozkee Jun 29, 2021
d656aed
Address suggestions
jozkee Jun 29, 2021
adcca16
Address suggestions about using PathInternal.IsExtended
jozkee Jun 29, 2021
35165b0
Add more scenarios for "file system entry type is inconsistent with t…
jozkee Jul 1, 2021
9d2694b
Remove duplicated validation checks
jozkee Jul 1, 2021
c79df26
Address suggestions for Unix
jozkee Jul 1, 2021
fc4241d
ifdef the list of paths used for theories
jozkee Jul 1, 2021
4881f2b
Add tests to verify the limit of followed links
jozkee Jul 2, 2021
b377cb0
Fix bug related to follow links limit in Unix
jozkee Jul 2, 2021
496487f
Trim extended prefix when the passed-in path is not extended
jozkee Jul 2, 2021
beaf701
Remove helper AssertFullNameEquals since is no longer needed and fix …
jozkee Jul 2, 2021
a5986fb
Add a check for versions < win10 build 14972 to fix silent error
jozkee Jul 2, 2021
b7ec269
Add Windows limit for ResolveLinkTarget to remarks
jozkee Jul 2, 2021
7f37a86
Remove pipe test
jozkee Jul 2, 2021
3e36f72
Remove lstat from ResolveLinkTarget
jozkee Jul 6, 2021
6f5b99a
Avoid testing the reparse point/soft link limit very precisely
jozkee Jul 8, 2021
2d09f7e
Fix LinkTarget invalidation logic
jozkee Jul 8, 2021
4b5e133
Make returnFinalTarget no longer optional
jozkee Jul 8, 2021
82dc88a
Merge branch 'main' of https://github.com/dotnet/runtime into symlinks
jozkee Jul 8, 2021
48e1af1
Try to fix failing tests found in CI
jozkee Jul 8, 2021
0495f59
Try smaller chains of links
jozkee Jul 8, 2021
40cb737
Avoid using GetTestFilePath in order to correctly compare against the…
jozkee Jul 9, 2021
995ead5
Use chain length of 20 instead of 30, which fails in Win 1809
jozkee Jul 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add IsBrowser check to CanCreateSymbolicLinks
  • Loading branch information
@carlossanlop @jozkee
carlossanlop authored and jozkee committed Jul 2, 2021
commit 6bb1aa9d8e30f823773c46a0f1040b5be2a7ceaf
2 changes: 1 addition & 1 deletion src/libraries/Common/tests/TestUtilities/System/IO/FileCleanupTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ protected static bool CreateSymLink(string targetPath, string linkPath, bool isD
#if NETFRAMEWORK
bool isWindows = true;
#else
if (OperatingSystem.IsIOS() || OperatingSystem.IsTvOS() || OperatingSystem.IsMacCatalyst()) // OSes that don't support Process.Start()
if (OperatingSystem.IsIOS() || OperatingSystem.IsTvOS() || OperatingSystem.IsMacCatalyst() || OperatingSystem.IsBrowser()) // OSes that don't support Process.Start()
{
return false;
}
Expand Down