Fix build failure. Address documentation suggestions.

src/libraries/Common/src/Interop/Windows/Kernel32/Interop.REPARSE_DATA_BUFFER.cs

@@ -9,28 +9,28 @@ internal static partial class Interop
     internal static partial class Kernel32
     {
         // https://docs.microsoft.com/windows-hardware/drivers/ifs/fsctl-get-reparse-point
-        public const int MAXIMUM_REPARSE_DATA_BUFFER_SIZE = 16 * 1024;
+        internal const int MAXIMUM_REPARSE_DATA_BUFFER_SIZE = 16 * 1024;
 
-        public const uint SYMLINK_FLAG_RELATIVE = 1;
+        internal const uint SYMLINK_FLAG_RELATIVE = 1;
 
         // https://msdn.microsoft.com/library/windows/hardware/ff552012.aspx
         // We don't need all the struct fields; omitting the rest.
         [StructLayout(LayoutKind.Sequential)]
-        public unsafe struct REPARSE_DATA_BUFFER
+        internal unsafe struct REPARSE_DATA_BUFFER
         {
-            public uint ReparseTag;
-            public ushort ReparseDataLength;
-            public ushort Reserved;
-            public SymbolicLinkReparseBuffer ReparseBufferSymbolicLink;
+            internal uint ReparseTag;
+            internal ushort ReparseDataLength;
+            internal ushort Reserved;
+            internal SymbolicLinkReparseBuffer ReparseBufferSymbolicLink;
 
             [StructLayout(LayoutKind.Sequential)]
-            public struct SymbolicLinkReparseBuffer
+            internal struct SymbolicLinkReparseBuffer
             {
-                public ushort SubstituteNameOffset;
-                public ushort SubstituteNameLength;
-                public ushort PrintNameOffset;
-                public ushort PrintNameLength;
-                public uint Flags;
+                internal ushort SubstituteNameOffset;
+                internal ushort SubstituteNameLength;
+                internal ushort PrintNameOffset;
+                internal ushort PrintNameLength;
+                internal uint Flags;
             }
         }
     }

src/libraries/System.Diagnostics.Process/src/System.Diagnostics.Process.csproj

@@ -233,6 +233,8 @@
              Link="Common\Interop\Unix\Interop.Errors.cs" />
     <Compile Include="$(CommonPath)Interop\Unix\System.Native\Interop.Close.cs"
              Link="Common\Interop\Unix\Interop.Close.cs" />
+    <Compile Include="$(CommonPath)Interop\Unix\Interop.DefaultPathBufferSize.cs"
+             Link="Common\Interop\Unix\Interop.DefaultPathBufferSize.cs" />
     <Compile Include="$(CommonPath)Interop\Unix\System.Native\Interop.GetHostName.cs"
              Link="Common\Interop\Unix\Interop.GetHostName.cs" />
     <Compile Include="$(CommonPath)Interop\Unix\System.Native\Interop.SysConf.cs"
@@ -261,6 +263,8 @@
              Link="Common\Interop\Unix\Interop.ResourceLimits.cs" />
     <Compile Include="$(CommonPath)Interop\Unix\System.Native\Interop.PathConf.cs"
              Link="Common\Interop\Unix\Interop.PathConf.cs" />
+    <Compile Include="$(CommonPath)System\Text\ValueUtf8Converter.cs"
+             Link="Common\System\Text\ValueUtf8Converter.cs" />
     <Compile Include="$(CommonPath)Interop\Unix\System.Native\Interop.WaitId.cs"
              Link="Common\Interop\Unix\Interop.WaitId.cs" />
     <Compile Include="$(CommonPath)Interop\Unix\System.Native\Interop.WaitPid.cs"

src/libraries/System.Net.Ping/src/System.Net.Ping.csproj

@@ -46,6 +46,8 @@
     <Compile Include="$(CommonPath)System\Net\NetworkInformation\UnixCommandLinePing.cs"
              Link="Common\System\Net\NetworkInformation\UnixCommandLinePing.cs" />
     <!-- Interop -->
+    <Compile Include="$(CommonPath)Interop\Unix\Interop.DefaultPathBufferSize.cs"
+             Link="Common\Interop\Unix\Interop.DefaultPathBufferSize.cs" />
     <Compile Include="$(CommonPath)Interop\Unix\Interop.Errors.cs"
              Link="Common\Interop\Unix\Interop.Errors.cs" />
     <Compile Include="$(CommonPath)Interop\Unix\Interop.Libraries.cs"
@@ -58,6 +60,8 @@
              Link="Common\Interop\Unix\System.Native\Interop.Socket.cs" />
     <Compile Include="$(CommonPath)Interop\Unix\System.Native\Interop.SocketAddress.cs"
              Link="Common\Interop\Unix\System.Native\Interop.SocketAddress.cs" />
+    <Compile Include="$(CommonPath)System\Text\ValueUtf8Converter.cs"
+             Link="Common\System\Text\ValueUtf8Converter.cs" />
   </ItemGroup>
   <ItemGroup Condition="'$(TargetsUnix)' == 'true' AND '$(TargetsApple)' != 'true'">
     <Compile Include="System\Net\NetworkInformation\Ping.Unix.cs" />

src/libraries/System.Private.CoreLib/src/Resources/Strings.resx

@@ -2660,7 +2660,7 @@
     <value>BindHandle for ThreadPool failed on this handle.</value>
   </data>
   <data name="IO_InconsistentLinkType" xml:space="preserve">
-    <value>The link file system type is inconsistent with the link target system type.</value>
+    <value>The link's file system entry type is inconsistent with that of its target.</value>
   </data>
   <data name="IO_FileExists_Name" xml:space="preserve">
     <value>The file '{0}' already exists.</value>

src/libraries/System.Private.CoreLib/src/System/IO/Directory.cs

@@ -344,7 +344,13 @@ public static FileSystemInfo CreateSymbolicLink(string path, string pathToTarget
         /// </summary>
         /// <param name="linkPath">The path of the directory link.</param>
         /// <param name="returnFinalTarget"><see langword="true"/> to follow links to the final target; <see langword="false"/> to return the immediate next link.</param>
-        /// <returns>A <see cref="DirectoryInfo"/> instance if <paramref name="linkPath"/> exists, independently if the target exists or not. <see langword="null"/> if <paramref name="linkPath"/> does not exist.</returns>
+        /// <returns>A <see cref="DirectoryInfo"/> instance if <paramref name="linkPath"/> exists, independently if the target exists or not. <see langword="null"/> if <paramref name="linkPath"/> is not a link.</returns>
+        /// <exception cref="IOException">The directory on <paramref name="linkPath"/> does not exist.
+        /// -or-
+        /// The link's file system entry type is inconsistent with that of its target.
+        /// -or-
+        /// Too many levels of symbolic links.</exception>
+        /// <remarks>When <paramref name="returnFinalTarget"/> is <see langword="true"/>, the maximum number of symbolic links that are followed are 40 on Unix.</remarks>
         public static System.IO.FileSystemInfo? ResolveLinkTarget(string linkPath, bool returnFinalTarget = false)
         {
             FileSystem.VerifyValidPath(linkPath, nameof(linkPath));

src/libraries/System.Private.CoreLib/src/System/IO/File.cs

@@ -1017,9 +1017,7 @@ private static async Task InternalWriteAllTextAsync(StreamWriter sw, string cont
         /// <exception cref="ArgumentNullException"><paramref name="path"/> or <paramref name="pathToTarget"/> is <see langword="null"/>.</exception>
         /// <exception cref="ArgumentException"><paramref name="path"/> or <paramref name="pathToTarget"/> is empty.
         /// -or-
-        /// <paramref name="path"/> is not an absolute path.
-        /// -or-
-        /// <paramref name="path"/> or <paramref name="pathToTarget"/> contains invalid path characters.</exception>
+        /// <paramref name="path"/> or <paramref name="pathToTarget"/> contains a null character.</exception>
         /// <exception cref="IOException">A file or directory already exists in the location of <paramref name="path"/>.
         /// -or-
         /// An I/O error occurred.</exception>
@@ -1036,7 +1034,13 @@ public static FileSystemInfo CreateSymbolicLink(string path, string pathToTarget
         /// </summary>
         /// <param name="linkPath">The path of the file link.</param>
         /// <param name="returnFinalTarget"><see langword="true"/> to follow links to the final target; <see langword="false"/> to return the immediate next link.</param>
-        /// <returns>A <see cref="FileInfo"/> instance if <paramref name="linkPath"/> exists, independently if the target exists or not. <see langword="null"/> if <paramref name="linkPath"/> does not exist.</returns>
+        /// <returns>A <see cref="FileInfo"/> instance if <paramref name="linkPath"/> exists, independently if the target exists or not. <see langword="null"/> if <paramref name="linkPath"/> is not a link.</returns>
+        /// <exception cref="IOException">The file on <paramref name="linkPath"/> does not exist.
+        /// -or-
+        /// The link's file system entry type is inconsistent with that of its target.
+        /// -or-
+        /// Too many levels of symbolic links.</exception>
+        /// <remarks>When <paramref name="returnFinalTarget"/> is <see langword="true"/>, the maximum number of symbolic links that are followed are 40 on Unix.</remarks>
         public static System.IO.FileSystemInfo? ResolveLinkTarget(string linkPath, bool returnFinalTarget = false)
         {
             FileSystem.VerifyValidPath(linkPath, nameof(linkPath));

src/libraries/System.Private.CoreLib/src/System/IO/FileSystem.Unix.cs

@@ -573,7 +573,7 @@ internal static void CreateSymbolicLink(string path, string pathToTarget, bool i
         /// <param name="isDirectory">True if the linkPath points to a directory or a symlink to a directory.</param>
         /// <returns>If the specified linkPath represents a link file and it exists, returns a FileInfo if isDirectory
         /// is false, or a DirectoryInfo if isDirectory is true, independently if the target file/directory exists or not.
-        /// If the specified linkPath is not a link file or it does not exist, returns null.</returns>
+        /// If the specified linkPath is not a link, returns null. Throws if the file or directory in linkPath does not exist.</returns>
         internal static FileSystemInfo? ResolveLinkTarget(string linkPath, bool returnFinalTarget, bool isDirectory)
         {
             // throws if the current link file does not exist

src/libraries/System.Private.CoreLib/src/System/IO/FileSystemInfo.cs

@@ -145,8 +145,13 @@ public void CreateAsSymbolicLink(string pathToTarget)
         /// Gets the target of the specified link.
         /// </summary>
         /// <param name="returnFinalTarget"><see langword="true"/> to follow links to the final target; <see langword="false"/> to return the immediate next link.</param>
-        /// <returns>A <see cref="FileSystemInfo"/> instance if the link exists, independently if the target exists or not; <see langword="null"/> if a link does not exist
-        /// in <see cref="FullName"/>, or this instance does not represent a link.</returns>
+        /// <returns>A <see cref="FileSystemInfo"/> instance if the link exists, independently if the target exists or not; <see langword="null"/> if this file or directory is not a link.</returns>
+        /// <exception cref="IOException">The file or directory does not exist.
+        /// -or-
+        /// The link's file system entry type is inconsistent with that of its target.
+        /// -or-
+        /// Too many levels of symbolic links.</exception>
+        /// <remarks>When <paramref name="returnFinalTarget"/> is <see langword="true"/>, the maximum number of symbolic links that are followed are 40 on Unix.</remarks>
         public FileSystemInfo? ResolveLinkTarget(bool returnFinalTarget = false) =>
             FileSystem.ResolveLinkTarget(FullPath, returnFinalTarget, this is DirectoryInfo);
 

src/libraries/System.Security.Cryptography.X509Certificates/src/System.Security.Cryptography.X509Certificates.csproj

@@ -324,10 +324,14 @@
              Link="Common\Interop\Unix\Interop.Libraries.cs" />
     <Compile Include="$(CommonPath)Interop\Unix\Interop.Errors.cs"
              Link="Common\Interop\Unix\Interop.Errors.cs" />
+    <Compile Include="$(CommonPath)Interop\Unix\Interop.DefaultPathBufferSize.cs"
+             Link="Common\Interop\Unix\Interop.DefaultPathBufferSize.cs" />
     <Compile Include="$(CommonPath)Interop\Unix\System.Native\Interop.Permissions.cs"
              Link="Common\Interop\Unix\System.Native\Interop.Permissions.cs" />
     <Compile Include="$(CommonPath)Interop\Unix\System.Native\Interop.ReadLink.cs"
              Link="Common\Interop\Unix\System.Native\Interop.ReadLink.cs" />
+    <Compile Include="$(CommonPath)System\Text\ValueUtf8Converter.cs"
+             Link="Common\System\Text\ValueUtf8Converter.cs" />
     <Compile Include="$(CommonPath)Interop\Unix\System.Security.Cryptography.Native\Interop.ASN1.cs"
              Link="Common\Interop\Unix\System.Security.Cryptography.Native\Interop.ASN1.cs" />
     <Compile Include="$(CommonPath)Interop\Unix\System.Security.Cryptography.Native\Interop.ASN1.GetIntegerBytes.cs"