Skip to content

Spill single-def variable at definition to avoid further spilling #54345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kunalspathak merged 20 commits into from
Jul 10, 2021
Merged

Spill single-def variable at definition to avoid further spilling #54345

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
d5dc108
Print single-def
kunalspathak Jun 16, 2021
5176e85
Rename lvEhWriteThruCandidate->lvSingleDefRegCandidate, introduce isS…
kunalspathak Jun 16, 2021
3262f3f
Introduce singleDefSpillAfter
kunalspathak Jun 17, 2021
bed12a0
jit format
kunalspathak Jun 17, 2021
62b1d57
some fixes
kunalspathak Jun 18, 2021
4563709
wip
kunalspathak Jun 18, 2021
4707548
Add check of isSingleDef in validateInterval()
kunalspathak Jun 28, 2021
2d67df2
Make isSingleDef during buildIntervals
kunalspathak Jun 29, 2021
12ef329
minor fix in lclvars.cpp
kunalspathak Jun 29, 2021
a5dbc39
some fixes after self CR
kunalspathak Jun 29, 2021
803e59e
Updated some comments
kunalspathak Jun 30, 2021
1171e15
Remove lvSpillAtSingleDef from some asserts
kunalspathak Jun 30, 2021
d792cfc
Use singleDefSpill information in getWeight()
kunalspathak Jun 30, 2021
25770df
Remove lvSpillAtSingleDef from some more checks
kunalspathak Jun 30, 2021
4d3b6b6
Mark lvSpillAtSingleDef whenever refPosition->singleDefSpill==true
kunalspathak Jul 1, 2021
22a1a7d
Add TODO for SingleDefVarCandidate
kunalspathak Jul 1, 2021
e3383c1
Some notes on setting singleDefSpill
kunalspathak Jul 1, 2021
8facc97
jit format
kunalspathak Jul 1, 2021
d3e03a6
review feedback
kunalspathak Jul 8, 2021
649c6c4
review comments
kunalspathak Jul 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
minor fix in lclvars.cpp
  • Loading branch information
@kunalspathak
kunalspathak committed Jul 9, 2021
commit 12ef329276ef9ec1104e983dbe3be469366973b8
7 changes: 4 additions & 3 deletions src/coreclr/jit/lclvars.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4112,12 +4112,13 @@ void Compiler::lvaMarkLclRefs(GenTree* tree, BasicBlock* block, Statement* stmt,

if (!varDsc->lvDisqualifySingleDefRegCandidate) // If this var is already disqualified, we can skip this
{
if ((tree->gtFlags & GTF_VAR_DEF) || (tree->gtFlags & GTF_VAR_CLONED)) // Is this is a def of our variable
varDsc->lvSpillAtSingleDef = false;

if (tree->gtFlags & GTF_VAR_DEF) // Is this is a def of our variable
{
bool bbInALoop = (block->bbFlags & BBF_BACKWARD_JUMP) != 0;
bool bbIsReturn = block->bbJumpKind == BBJ_RETURN;
bool needsExplicitZeroInit = fgVarNeedsExplicitZeroInit(lclNum, bbInALoop, bbIsReturn);
varDsc->lvSpillAtSingleDef = false;

if (varDsc->lvSingleDefRegCandidate || needsExplicitZeroInit)
{
Expand Down Expand Up @@ -7425,7 +7426,7 @@ void Compiler::lvaDumpEntry(unsigned lclNum, FrameLayoutState curState, size_t r
}
if (lvaEnregEHVars && varDsc->lvLiveInOutOfHndlr)
{
printf("%c", varDsc->lvDisqualifySingleDefRegCandidate);
printf("%c", varDsc->lvSingleDefDisqualifyReason);
}
if (varDsc->lvLclFieldExpr)
{
Expand Down