Replace usages of Marshal.AllocHGlobal with malloc in libraries

src/libraries/Common/src/Interop/Android/System.Security.Cryptography.Native.Android/Interop.X509Chain.cs

@@ -62,9 +62,9 @@ internal static X509Certificate2[] X509ChainGetCertificates(SafeX509ChainContext
         }
 
         [StructLayout(LayoutKind.Sequential)]
-        internal struct ValidationError
+        internal unsafe struct ValidationError
         {
-            public IntPtr Message; // UTF-16 string
+            public char* Message; // UTF-16 string
             public int Index;
             public int Status;
         }

src/libraries/Common/src/Interop/BSD/System.Native/Interop.Sysctl.cs

@@ -33,7 +33,7 @@ internal static unsafe void Sysctl(Span<int> name, ref byte* value, ref int len)
 
         private static unsafe void Sysctl(int* name, int name_len, ref byte* value, ref int len)
         {
-            IntPtr bytesLength = (IntPtr)len;
+            var bytesLength = (nint)len;
             int ret = -1;
             bool autoSize = (value == null && len == 0);
 
@@ -45,36 +45,36 @@ private static unsafe void Sysctl(int* name, int name_len, ref byte* value, ref
                 {
                     throw new InvalidOperationException(SR.Format(SR.InvalidSysctl, *name, Marshal.GetLastWin32Error()));
                 }
-                value = (byte*)Marshal.AllocHGlobal((int)bytesLength);
+                value = (byte*)NativeMemory.Alloc((nuint)bytesLength);
             }
 
             ret = Sysctl(name, name_len, value, &bytesLength);
             while (autoSize && ret != 0 && GetLastErrorInfo().Error == Error.ENOMEM)
             {
-                // Do not use ReAllocHGlobal() here: we don't care about
+                // Do not use Realloc here: we don't care about
                 // previous contents, and proper checking of value returned
                 // will make code more complex.
-                Marshal.FreeHGlobal((IntPtr)value);
+                NativeMemory.Free(value);
                 if ((int)bytesLength == int.MaxValue)
                 {
                     throw new OutOfMemoryException();
                 }
                 if ((int)bytesLength >= int.MaxValue / 2)
                 {
-                    bytesLength = (IntPtr)int.MaxValue;
+                    bytesLength = int.MaxValue;
                 }
                 else
                 {
-                    bytesLength = (IntPtr)((int)bytesLength * 2);
+                    bytesLength = ((int)bytesLength * 2);
                 }
-                value = (byte*)Marshal.AllocHGlobal(bytesLength);
+                value = (byte*)NativeMemory.Alloc((nuint)bytesLength);
                 ret = Sysctl(name, name_len, value, &bytesLength);
             }
             if (ret != 0)
             {
                 if (autoSize)
                 {
-                    Marshal.FreeHGlobal((IntPtr)value);
+                    NativeMemory.Free(value);
                 }
                 throw new InvalidOperationException(SR.Format(SR.InvalidSysctl, *name, Marshal.GetLastWin32Error()));
             }

src/libraries/Common/src/Interop/Linux/OpenLdap/Interop.Ber.cs

@@ -87,7 +87,7 @@ public static int ber_printf_int(SafeBerHandle berElement, string format, int va
         [DllImport(Libraries.OpenLdap, EntryPoint = "ber_put_boolean", CharSet = CharSet.Ansi)]
         public static extern int ber_put_boolean(SafeBerHandle berElement, int value, nuint tag);
 
-        public static int ber_printf_bytearray(SafeBerHandle berElement, string format, HGlobalMemHandle value, nuint length, nuint tag)
+        public static int ber_printf_bytearray(SafeBerHandle berElement, string format, NativeMemoryHandle value, nuint length, nuint tag)
         {
             if (format == "o")
             {
@@ -105,13 +105,13 @@ public static int ber_printf_bytearray(SafeBerHandle berElement, string format,
         }
 
         [DllImport(Libraries.OpenLdap, EntryPoint = "ber_put_ostring", CharSet = CharSet.Ansi)]
-        private static extern int ber_put_ostring(SafeBerHandle berElement, HGlobalMemHandle value, nuint length, nuint tag);
+        private static extern int ber_put_ostring(SafeBerHandle berElement, NativeMemoryHandle value, nuint length, nuint tag);
 
         [DllImport(Libraries.OpenLdap, EntryPoint = "ber_put_string", CharSet = CharSet.Ansi)]
-        private static extern int ber_put_string(SafeBerHandle berElement, HGlobalMemHandle value, nuint tag);
+        private static extern int ber_put_string(SafeBerHandle berElement, NativeMemoryHandle value, nuint tag);
 
         [DllImport(Libraries.OpenLdap, EntryPoint = "ber_put_bitstring", CharSet = CharSet.Ansi)]
-        private static extern int ber_put_bitstring(SafeBerHandle berElement, HGlobalMemHandle value, nuint length, nuint tag);
+        private static extern int ber_put_bitstring(SafeBerHandle berElement, NativeMemoryHandle value, nuint length, nuint tag);
 
         [DllImport(Libraries.OpenLdap, EntryPoint = "ber_flatten", CharSet = CharSet.Ansi)]
         public static extern int ber_flatten(SafeBerHandle berElement, ref IntPtr value);

src/libraries/Common/src/Interop/Linux/OpenLdap/Interop.Ldap.cs

@@ -63,7 +63,7 @@ internal static partial class Interop
 {
     public const string LDAP_SASL_SIMPLE = null;
 
-    internal static partial class Ldap
+    internal static unsafe partial class Ldap
     {
         static Ldap()
         {
@@ -155,7 +155,7 @@ static Ldap()
         internal static extern int ldap_sasl_bind([In] ConnectionHandle ld, string dn, string mechanism, berval cred, IntPtr serverctrls, IntPtr clientctrls, IntPtr servercredp);
 
         [DllImport(Libraries.OpenLdap, EntryPoint = "ldap_sasl_interactive_bind_s", CharSet = CharSet.Ansi)]
-        internal static extern int ldap_sasl_interactive_bind([In] ConnectionHandle ld, string dn, string mechanism, IntPtr serverctrls, IntPtr clientctrls, uint flags, [MarshalAs(UnmanagedType.FunctionPtr)] LDAP_SASL_INTERACT_PROC proc, IntPtr defaults);
+        internal static extern int ldap_sasl_interactive_bind([In] ConnectionHandle ld, string dn, string mechanism, IntPtr serverctrls, IntPtr clientctrls, uint flags, [MarshalAs(UnmanagedType.FunctionPtr)] LDAP_SASL_INTERACT_PROC proc, void* defaults);
 
         [DllImport(Libraries.OpenLdap, EntryPoint = "ldap_err2string", CharSet = CharSet.Ansi)]
         public static extern IntPtr ldap_err2string(int err);
@@ -173,7 +173,7 @@ static Ldap()
         public static extern IntPtr ldap_first_reference([In] ConnectionHandle ldapHandle, [In] IntPtr result);
 
         [DllImport(Libraries.OpenLdap, EntryPoint = "ldap_create_sort_control", CharSet = CharSet.Ansi)]
-        public static extern int ldap_create_sort_control(ConnectionHandle handle, IntPtr keys, byte critical, ref IntPtr control);
+        public static extern int ldap_create_sort_control(ConnectionHandle handle, void** keys, byte critical, ref IntPtr control);
 
         [DllImport(Libraries.OpenLdap, EntryPoint = "ldap_control_free", CharSet = CharSet.Ansi)]
         public static extern int ldap_control_free(IntPtr control);
@@ -212,10 +212,10 @@ static Ldap()
         public static extern int ldap_add([In] ConnectionHandle ldapHandle, string dn, IntPtr attrs, IntPtr servercontrol, IntPtr clientcontrol, ref int messageNumber);
 
         [DllImport(Libraries.OpenLdap, EntryPoint = "ldap_delete_ext", CharSet = CharSet.Ansi)]
-        public static extern int ldap_delete_ext([In] ConnectionHandle ldapHandle, string dn, IntPtr servercontrol, IntPtr clientcontrol, ref int messageNumber);
+        public static extern int ldap_delete_ext([In] ConnectionHandle ldapHandle, string dn, void** servercontrol, void** clientcontrol, ref int messageNumber);
 
         [DllImport(Libraries.OpenLdap, EntryPoint = "ldap_rename", CharSet = CharSet.Ansi)]
-        public static extern int ldap_rename([In] ConnectionHandle ldapHandle, string dn, string newRdn, string newParentDn, int deleteOldRdn, IntPtr servercontrol, IntPtr clientcontrol, ref int messageNumber);
+        public static extern int ldap_rename([In] ConnectionHandle ldapHandle, string dn, string newRdn, string newParentDn, int deleteOldRdn, void** servercontrol, void** clientcontrol, ref int messageNumber);
 
         [DllImport(Libraries.OpenLdap, EntryPoint = "ldap_compare_ext", CharSet = CharSet.Ansi)]
         public static extern int ldap_compare([In] ConnectionHandle ldapHandle, string dn, string attributeName, berval binaryValue, IntPtr servercontrol, IntPtr clientcontrol, ref int messageNumber);

src/libraries/Common/src/Interop/Unix/System.Native/Interop.ForkAndExecProcess.cs

@@ -53,7 +53,7 @@ private static unsafe void AllocNullTerminatedArray(string[] arr, ref byte** arr
 
             // Allocate the unmanaged array to hold each string pointer.
             // It needs to have an extra element to null terminate the array.
-            arrPtr = (byte**)Marshal.AllocHGlobal(sizeof(IntPtr) * arrLength);
+            arrPtr = (byte**)NativeMemory.Alloc((uint)(sizeof(IntPtr) * arrLength));
             Debug.Assert(arrPtr != null);
 
             // Zero the memory so that if any of the individual string allocations fails,
@@ -70,10 +70,10 @@ private static unsafe void AllocNullTerminatedArray(string[] arr, ref byte** arr
             {
                 byte[] byteArr = Encoding.UTF8.GetBytes(arr[i]);
 
-                arrPtr[i] = (byte*)Marshal.AllocHGlobal(byteArr.Length + 1); //+1 for null termination
+                arrPtr[i] = (byte*)NativeMemory.Alloc((uint)(byteArr.Length + 1u)); //+1 for null termination
                 Debug.Assert(arrPtr[i] != null);
 
-                Marshal.Copy(byteArr, 0, (IntPtr)arrPtr[i], byteArr.Length); // copy over the data from the managed byte array
+                Marshal.Copy(byteArr, 0, (nint)arrPtr[i], byteArr.Length); // copy over the data from the managed byte array
                 arrPtr[i][byteArr.Length] = (byte)'\0'; // null terminate
             }
         }
@@ -87,13 +87,13 @@ private static unsafe void FreeArray(byte** arr, int length)
                 {
                     if (arr[i] != null)
                     {
-                        Marshal.FreeHGlobal((IntPtr)arr[i]);
+                        NativeMemory.Free(arr[i]);
                         arr[i] = null;
                     }
                 }
 
                 // And then the array itself
-                Marshal.FreeHGlobal((IntPtr)arr);
+                NativeMemory.Free(arr);
             }
         }
     }

src/libraries/Common/src/Interop/Windows/Advapi32/Interop.ConvertStringSecurityDescriptorToSecurityDescriptor.cs

@@ -13,7 +13,7 @@ internal static partial class Advapi32
         internal static extern bool ConvertStringSecurityDescriptorToSecurityDescriptor(
                 string StringSecurityDescriptor,
                 int StringSDRevision,
-                out SafeLocalAllocHandle pSecurityDescriptor,
+                out SafeNativeMemoryHandle pSecurityDescriptor,
                 IntPtr SecurityDescriptorSize);
     }
 }

src/libraries/Common/src/Interop/Windows/Advapi32/Interop.GetTokenInformation.cs

@@ -13,15 +13,15 @@ internal static partial class Advapi32
         internal static extern bool GetTokenInformation(
             SafeAccessTokenHandle TokenHandle,
             uint TokenInformationClass,
-            SafeLocalAllocHandle TokenInformation,
+            SafeNativeMemoryHandle TokenInformation,
             uint TokenInformationLength,
             out uint ReturnLength);
 
         [DllImport(Interop.Libraries.Advapi32, SetLastError = true)]
         internal static extern bool GetTokenInformation(
             IntPtr TokenHandle,
             uint TokenInformationClass,
-            SafeLocalAllocHandle TokenInformation,
+            SafeNativeMemoryHandle TokenInformation,
             uint TokenInformationLength,
             out uint ReturnLength);
 

src/libraries/Common/src/Interop/Windows/BCrypt/Interop.AsymmetricEncryption.Types.cs

@@ -13,12 +13,12 @@ internal static partial class Interop
     internal static partial class BCrypt
     {
         [StructLayout(LayoutKind.Sequential)]
-        internal struct BCRYPT_OAEP_PADDING_INFO
+        internal unsafe struct BCRYPT_OAEP_PADDING_INFO
         {
             /// <summary>
             ///     Null-terminated Unicode string that identifies the hashing algorithm used to create the padding.
             /// </summary>
-            internal IntPtr pszAlgId;
+            internal char* pszAlgId;
 
             /// <summary>
             ///     Address of a buffer that contains the data used to create the padding.
@@ -32,21 +32,21 @@ internal struct BCRYPT_OAEP_PADDING_INFO
         }
 
         [StructLayout(LayoutKind.Sequential)]
-        internal struct BCRYPT_PKCS1_PADDING_INFO
+        internal unsafe struct BCRYPT_PKCS1_PADDING_INFO
         {
             /// <summary>
             ///     Null-terminated Unicode string that identifies the hashing algorithm used to create the padding.
             /// </summary>
-            internal IntPtr pszAlgId;
+            internal char* pszAlgId;
         }
 
         [StructLayout(LayoutKind.Sequential)]
-        internal struct BCRYPT_PSS_PADDING_INFO
+        internal unsafe struct BCRYPT_PSS_PADDING_INFO
         {
             /// <summary>
             ///     Null-terminated Unicode string that identifies the hashing algorithm used to create the padding.
             /// </summary>
-            internal IntPtr pszAlgId;
+            internal char* pszAlgId;
 
             /// <summary>
             ///     The size, in bytes, of the random salt to use for the padding.

src/libraries/Common/src/Interop/Windows/BCrypt/Interop.Blobs.cs

@@ -271,11 +271,11 @@ internal struct BCryptBuffer
         ///     Contains a set of generic CNG buffers.
         /// </summary>
         [StructLayout(LayoutKind.Sequential)]
-        internal struct BCryptBufferDesc
+        internal unsafe struct BCryptBufferDesc
         {
             internal int ulVersion;            // Version number
             internal int cBuffers;             // Number of buffers
-            internal IntPtr pBuffers;          // Pointer to array of BCryptBuffers
+            internal BCryptBuffer* pBuffers;   // Pointer to array of BCryptBuffers
         }
 
         /// <summary>

src/libraries/Common/src/Interop/Windows/HttpApi/Interop.HttpApi.cs

@@ -484,7 +484,7 @@ internal static extern unsafe uint HttpCreateRequestQueue(HTTPAPI_VERSION versio
         internal static extern unsafe uint HttpReceiveHttpRequest(SafeHandle requestQueueHandle, ulong requestId, uint flags, HTTP_REQUEST* pRequestBuffer, uint requestBufferLength, uint* pBytesReturned, NativeOverlapped* pOverlapped);
 
         [DllImport(Libraries.HttpApi, SetLastError = true)]
-        internal static extern unsafe uint HttpSendHttpResponse(SafeHandle requestQueueHandle, ulong requestId, uint flags, HTTP_RESPONSE* pHttpResponse, void* pCachePolicy, uint* pBytesSent, SafeLocalAllocHandle pRequestBuffer, uint requestBufferLength, NativeOverlapped* pOverlapped, void* pLogData);
+        internal static extern unsafe uint HttpSendHttpResponse(SafeHandle requestQueueHandle, ulong requestId, uint flags, HTTP_RESPONSE* pHttpResponse, void* pCachePolicy, uint* pBytesSent, SafeNativeMemoryHandle pRequestBuffer, uint requestBufferLength, NativeOverlapped* pOverlapped, void* pLogData);
 
         [DllImport(Libraries.HttpApi, SetLastError = true)]
         internal static extern unsafe uint HttpWaitForDisconnect(SafeHandle requestQueueHandle, ulong connectionId, NativeOverlapped* pOverlapped);
@@ -493,7 +493,7 @@ internal static extern unsafe uint HttpCreateRequestQueue(HTTPAPI_VERSION versio
         internal static extern unsafe uint HttpReceiveRequestEntityBody(SafeHandle requestQueueHandle, ulong requestId, uint flags, void* pEntityBuffer, uint entityBufferLength, out uint bytesReturned, NativeOverlapped* pOverlapped);
 
         [DllImport(Libraries.HttpApi, SetLastError = true)]
-        internal static extern unsafe uint HttpSendResponseEntityBody(SafeHandle requestQueueHandle, ulong requestId, uint flags, ushort entityChunkCount, HTTP_DATA_CHUNK* pEntityChunks, uint* pBytesSent, SafeLocalAllocHandle pRequestBuffer, uint requestBufferLength, NativeOverlapped* pOverlapped, void* pLogData);
+        internal static extern unsafe uint HttpSendResponseEntityBody(SafeHandle requestQueueHandle, ulong requestId, uint flags, ushort entityChunkCount, HTTP_DATA_CHUNK* pEntityChunks, uint* pBytesSent, SafeNativeMemoryHandle pRequestBuffer, uint requestBufferLength, NativeOverlapped* pOverlapped, void* pLogData);
 
         [DllImport(Libraries.HttpApi, SetLastError = true)]
         internal static extern uint HttpCloseRequestQueue(IntPtr pReqQueueHandle);
@@ -515,17 +515,17 @@ public override int Size
                 get { return _size; }
             }
 
-            public static SafeLocalFreeChannelBinding LocalAlloc(int cb)
+            public static unsafe SafeLocalFreeChannelBinding Alloc(int cb)
             {
                 SafeLocalFreeChannelBinding result = new SafeLocalFreeChannelBinding();
-                result.SetHandle(Marshal.AllocHGlobal(cb));
+                result.SetHandle((nint)NativeMemory.Alloc((uint)cb));
                 result._size = cb;
                 return result;
             }
 
-            protected override bool ReleaseHandle()
+            protected override unsafe bool ReleaseHandle()
             {
-                Marshal.FreeHGlobal(handle);
+                NativeMemory.Free((void*)(nint)handle);
                 return true;
             }
         }

src/libraries/Common/src/Interop/Windows/IpHlpApi/Interop.ICMP.cs

@@ -100,10 +100,10 @@ protected override bool ReleaseHandle()
 
         [DllImport(Interop.Libraries.IpHlpApi, SetLastError = true)]
         internal static extern uint IcmpSendEcho2(SafeCloseIcmpHandle icmpHandle, SafeWaitHandle Event, IntPtr apcRoutine, IntPtr apcContext,
-            uint ipAddress, [In] SafeLocalAllocHandle data, ushort dataSize, ref IPOptions options, SafeLocalAllocHandle replyBuffer, uint replySize, uint timeout);
+            uint ipAddress, [In] SafeNativeMemoryHandle data, ushort dataSize, ref IPOptions options, SafeNativeMemoryHandle replyBuffer, uint replySize, uint timeout);
 
         [DllImport(Interop.Libraries.IpHlpApi, SetLastError = true)]
         internal static extern uint Icmp6SendEcho2(SafeCloseIcmpHandle icmpHandle, SafeWaitHandle Event, IntPtr apcRoutine, IntPtr apcContext,
-            byte[] sourceSocketAddress, byte[] destSocketAddress, [In] SafeLocalAllocHandle data, ushort dataSize, ref IPOptions options, SafeLocalAllocHandle replyBuffer, uint replySize, uint timeout);
+            byte[] sourceSocketAddress, byte[] destSocketAddress, [In] SafeNativeMemoryHandle data, ushort dataSize, ref IPOptions options, SafeNativeMemoryHandle replyBuffer, uint replySize, uint timeout);
     }
 }

src/libraries/Common/src/Interop/Windows/NCrypt/Interop.Keys.cs

@@ -17,7 +17,7 @@ internal static partial class NCrypt
         internal static extern ErrorCode NCryptOpenKey(SafeNCryptProviderHandle hProvider, out SafeNCryptKeyHandle phKey, string pszKeyName, int dwLegacyKeySpec, CngKeyOpenOptions dwFlags);
 
         [DllImport(Interop.Libraries.NCrypt, CharSet = CharSet.Unicode)]
-        internal static extern ErrorCode NCryptImportKey(SafeNCryptProviderHandle hProvider, IntPtr hImportKey, string pszBlobType, IntPtr pParameterList, [Out] out SafeNCryptKeyHandle phKey, ref byte pbData, int cbData, int dwFlags);
+        internal static unsafe extern ErrorCode NCryptImportKey(SafeNCryptProviderHandle hProvider, IntPtr hImportKey, string pszBlobType, NCryptBufferDesc* pParameterList, [Out] out SafeNCryptKeyHandle phKey, ref byte pbData, int cbData, int dwFlags);
 
         [DllImport(Interop.Libraries.NCrypt, CharSet = CharSet.Unicode)]
         internal static extern ErrorCode NCryptImportKey(SafeNCryptProviderHandle hProvider, IntPtr hImportKey, string pszBlobType, ref NCryptBufferDesc pParameterList, [Out] out SafeNCryptKeyHandle phKey, ref byte pbData, int cbData, int dwFlags);

src/libraries/Common/src/Interop/Windows/WinHttp/Interop.winhttp.cs

@@ -117,10 +117,10 @@ public static extern bool WinHttpQueryOption(
 
         [DllImport(Interop.Libraries.WinHttp, CharSet = CharSet.Unicode, SetLastError = true)]
         [return: MarshalAs(UnmanagedType.Bool)]
-        public static extern bool WinHttpQueryOption(
+        public static extern unsafe bool WinHttpQueryOption(
             SafeWinHttpHandle handle,
             uint option,
-            IntPtr buffer,
+            void* buffer,
             ref uint bufferSize);
 
         [DllImport(Interop.Libraries.WinHttp, CharSet = CharSet.Unicode, SetLastError = true)]