-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[wasm][http] Improve compatibility of abort and cancelation of BrowserHttpHandler #55084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][http] Improve compatibility of abort and cancelation of BrowserHttpHandler #55084
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue Details
Fixes #54270
|
ManickaP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'm not a browser handler expert though.
src/libraries/System.Net.Http/src/System/Net/Http/BrowserHttpHandler/BrowserHttpHandler.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Http/src/System/Net/Http/BrowserHttpHandler/BrowserHttpHandler.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Http/src/System/Net/Http/BrowserHttpHandler/BrowserHttpHandler.cs
Outdated
Show resolved
Hide resolved
… expectations
added [ActiveIssue("dotnet#55083", TestPlatforms.Browser)] for redirect outerloop tests
b17546d to
139ca9c
Compare
|
Is this ready for merge? |
|
Failing test in runtime (Libraries Test Run release mono Linux x64 Debug) is It isn't related to to a browser only change. |
Fixes #54270