Skip to content

[hot_reload] Add support for row modifications; CustomAttribute updates #55445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lambdageek merged 7 commits into from
Jul 12, 2021
Merged

[hot_reload] Add support for row modifications; CustomAttribute updates #55445

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
207c2e4
[hot_reload] Add test for updating custom attribute ctor values
lambdageek Jul 8, 2021
4a643f1
[hot_reload] Allow custom attribute row modifications if Parent and Type
lambdageek Jul 9, 2021
8a437bd
[hot_reload] Implement table lookup of modified rows
lambdageek Jul 10, 2021
e2dc8fb
Update the CustomAttributeUpdates test to check attribute value
lambdageek Jul 10, 2021
01f6e69
Re-enable nullability for hot reload tests
lambdageek Jul 10, 2021
3bbf510
fixup copy/paste mistake
lambdageek Jul 10, 2021
928ac23
Remove duplicated code; outdated comments
lambdageek Jul 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Re-enable nullability for hot reload tests 
Mono can now deal with the custom attributes modifications that Roslyn emits
  • Loading branch information
@lambdageek
lambdageek committed Jul 10, 2021
commit 01f6e69f9c6b88e0355b4d5b1d4635188ba145e7
1 change: 0 additions & 1 deletion ...mAttributeUpdate/System.Reflection.Metadata.ApplyUpdate.Test.CustomAttributeUpdate.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
<TargetFrameworks>$(NetCoreAppCurrent)</TargetFrameworks>
<TestRuntime>true</TestRuntime>
<DeltaScript>deltascript.json</DeltaScript>
<Nullable>disable</Nullable>
</PropertyGroup>
<ItemGroup>
<Compile Include="CustomAttributeUpdate.cs" />
Expand Down
1 change: 0 additions & 1 deletion ...plyUpdate.Test.MethodBody1/System.Reflection.Metadata.ApplyUpdate.Test.MethodBody1.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<TestRuntime>true</TestRuntime>
<DeltaScript>deltascript.json</DeltaScript>
<SkipTestUtilitiesReference>true</SkipTestUtilitiesReference>
<Nullable>disable</Nullable>
</PropertyGroup>
<ItemGroup>
<Compile Include="MethodBody1.cs" />
Expand Down
1 change: 0 additions & 1 deletion ...mbly/Browser/HotReload/ApplyUpdateReferencedAssembly/ApplyUpdateReferencedAssembly.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
<!-- hot reload is not compatible with trimming -->
<EnableAggressiveTrimming>false</EnableAggressiveTrimming>
<PublishTrimmed>false</PublishTrimmed>
<Nullable>disable</Nullable>
</PropertyGroup>

<ItemGroup>
Expand Down