Skip to content

[hot_reload] Add support for row modifications; CustomAttribute updates #55445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lambdageek merged 7 commits into from
Jul 12, 2021
Merged

[hot_reload] Add support for row modifications; CustomAttribute updates #55445

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
207c2e4
[hot_reload] Add test for updating custom attribute ctor values
lambdageek Jul 8, 2021
4a643f1
[hot_reload] Allow custom attribute row modifications if Parent and Type
lambdageek Jul 9, 2021
8a437bd
[hot_reload] Implement table lookup of modified rows
lambdageek Jul 10, 2021
e2dc8fb
Update the CustomAttributeUpdates test to check attribute value
lambdageek Jul 10, 2021
01f6e69
Re-enable nullability for hot reload tests
lambdageek Jul 10, 2021
3bbf510
fixup copy/paste mistake
lambdageek Jul 10, 2021
928ac23
Remove duplicated code; outdated comments
lambdageek Jul 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update the CustomAttributeUpdates test to check attribute value 
Check that we get the updated custom attribute string property value.
  • Loading branch information
@lambdageek
lambdageek committed Jul 10, 2021
commit e2dc8fbc7acbbd70fe92ab25d675ea2b104e36d1
15 changes: 14 additions & 1 deletion src/libraries/System.Runtime.Loader/tests/ApplyUpdateTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,20 @@ public void CustomAttributeUpdates()
ApplyUpdateUtil.ApplyUpdate(assm);
ApplyUpdateUtil.ClearAllReflectionCaches();

Assert.True(true); // just check that the update loaded
// Just check the updated value on one method

Type attrType = typeof(System.Reflection.Metadata.ApplyUpdate.Test.MyAttribute);
Type ty = assm.GetType("System.Reflection.Metadata.ApplyUpdate.Test.ClassWithCustomAttributeUpdates");
Assert.NotNull(ty);
MethodInfo mi = ty.GetMethod(nameof(System.Reflection.Metadata.ApplyUpdate.Test.ClassWithCustomAttributeUpdates.Method1), BindingFlags.Public | BindingFlags.Static);
Assert.NotNull(mi);
var cattrs = Attribute.GetCustomAttributes(mi, attrType);
Assert.NotNull(cattrs);
Assert.Equal(1, cattrs.Length);
Assert.NotNull(cattrs[0]);
Assert.Equal(attrType, cattrs[0].GetType());
string p = (cattrs[0] as System.Reflection.Metadata.ApplyUpdate.Test.MyAttribute).StringValue;
Assert.Equal("rstuv", p);
});
}

Expand Down