Skip to content

[wasm][debugger] Implement support to DebuggerDisplay attribute #55524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thaystg merged 6 commits into from
Jul 14, 2021
Merged

[wasm][debugger] Implement support to DebuggerDisplay attribute #55524

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
107ccd8
Support DebuggerDisplay attribute on type.
thaystg Jul 12, 2021
a8fb8cf
Merge branch 'main' of github.com:thaystg/runtime into thays_support_…
thaystg Jul 14, 2021
58c0108
Implementing DebuggerDisplay calling methods.
thaystg Jul 14, 2021
fa91a1e
Apply suggestions from code review
thaystg Jul 14, 2021
c55c8b0
Fixing snake case.
thaystg Jul 14, 2021
7c64b5d
Changing snake case.
thaystg Jul 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Changing snake case.
  • Loading branch information
@thaystg
thaystg committed Jul 14, 2021
commit 7c64b5d2182f37304ddb570933277548cb43cdda
14 changes: 7 additions & 7 deletions src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ internal class MemberReferenceResolver
private ExecutionContext ctx;
private PerScopeCache scopeCache;
private ILogger logger;
private bool locals_fetched;
private bool localsFetched;

public MemberReferenceResolver(MonoProxy proxy, ExecutionContext ctx, SessionId sessionId, int scopeId, ILogger logger)
{
Expand All @@ -34,15 +34,15 @@ public MemberReferenceResolver(MonoProxy proxy, ExecutionContext ctx, SessionId
scopeCache = ctx.GetCacheForScope(scopeId);
}

public MemberReferenceResolver(MonoProxy proxy, ExecutionContext ctx, SessionId session_id, JArray object_values, ILogger logger)
public MemberReferenceResolver(MonoProxy proxy, ExecutionContext ctx, SessionId sessionId, JArray objectValues, ILogger logger)
{
sessionId = session_id;
this.sessionId = sessionId;
scopeId = -1;
this.proxy = proxy;
this.ctx = ctx;
this.logger = logger;
scopeCache = new PerScopeCache(object_values);
locals_fetched = true;
scopeCache = new PerScopeCache(objectValues);
localsFetched = true;
}

public async Task<JObject> GetValueFromObject(JToken objRet, CancellationToken token)
Expand Down Expand Up @@ -113,12 +113,12 @@ public async Task<JObject> Resolve(string varName, CancellationToken token)
}
continue;
}
if (scopeCache.Locals.Count == 0 && !locals_fetched)
if (scopeCache.Locals.Count == 0 && !localsFetched)
{
Result scope_res = await proxy.GetScopeProperties(sessionId, scopeId, token);
if (scope_res.IsErr)
throw new Exception($"BUG: Unable to get properties for scope: {scopeId}. {scope_res}");
locals_fetched = true;
localsFetched = true;
}
if (scopeCache.Locals.TryGetValue(partTrimmed, out JObject obj))
{
Expand Down