Skip to content

[wasm][debugger] Implement support to DebuggerDisplay attribute #55524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thaystg merged 6 commits into from
Jul 14, 2021
Merged

[wasm][debugger] Implement support to DebuggerDisplay attribute #55524

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
107ccd8
Support DebuggerDisplay attribute on type.
thaystg Jul 12, 2021
a8fb8cf
Merge branch 'main' of github.com:thaystg/runtime into thays_support_…
thaystg Jul 14, 2021
58c0108
Implementing DebuggerDisplay calling methods.
thaystg Jul 14, 2021
fa91a1e
Apply suggestions from code review
thaystg Jul 14, 2021
c55c8b0
Fixing snake case.
thaystg Jul 14, 2021
7c64b5d
Changing snake case.
thaystg Jul 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Larry Ewing <[email protected]>
  • Loading branch information
@thaystg @lewing
thaystg and lewing authored Jul 14, 2021
commit fa91a1e843a4573d30c2e0f914a1140df3e667c8
2 changes: 1 addition & 1 deletion src/mono/wasm/debugger/DebuggerTestSuite/CustomViewTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public async Task CustomView()

var locals = await GetProperties(pause_location["callFrames"][0]["callFrameId"].Value<string>());
CheckObject(locals, "a", "DebuggerTests.WithDisplayString", description:"Some one Value 2 End");
CheckObject(locals, "c", "DebuggerTests.DebuggerDisplayMethodTest", description: "First Int:32 Second Int:43");
CheckObject(locals, "c", "DebuggerTests.DebuggerDisplayMethodTest", description: "First Int:32 Second Int:43");
}
}
}
6 changes: 3 additions & 3 deletions src/mono/wasm/debugger/tests/debugger-test/debugger-custom-view-test.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

namespace DebuggerTests
{
[DebuggerDisplay ("Some {Val1} Value {Val2} End")]
[DebuggerDisplay("Some {Val1} Value {Val2} End")]
class WithDisplayString
{
internal string Val1 = "one";
Expand All @@ -24,7 +24,7 @@ public override string ToString ()
}
}

[DebuggerTypeProxy (typeof(TheProxy))]
[DebuggerTypeProxy(typeof(TheProxy))]
class WithProxy
{
public string Val1 {
Expand All @@ -46,7 +46,7 @@ public string Val2 {
}
}

[DebuggerDisplay ("{GetDebuggerDisplay(), nq}")]
[DebuggerDisplay("{GetDebuggerDisplay(), nq}")]
class DebuggerDisplayMethodTest
{
int someInt = 32;
Expand Down