Skip to content

[wasm] Fix regression in compiling .bc -> .o files #56063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lewing merged 8 commits into from
Jul 21, 2021
Merged

[wasm] Fix regression in compiling .bc -> .o files #56063

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
346dcf7
[wasm] Add back --emit-llvm that got removed mistakenly, in an earlie…
radical Jul 20, 2021
67254e7
[wasm] Set EmccCompile's messages to MessageImportance.Low by default.
radical Jul 20, 2021
d61c225
[wasm] Quote filenames passed to emcc compile command line
radical Jul 20, 2021
03ad383
Add more blazorwasm tests - for debug/release, aot/relinking
radical Jul 21, 2021
732b9af
Bump sdk for workload testing to 6.0.100-rc.1.21370.2
radical Jul 21, 2021
887d8af
[wasm] Fix regression in compiling bitcode -> .o
radical Jul 21, 2021
ae715ae
Merge remote-tracking branch 'origin/main'
radical Jul 21, 2021
a63ca22
Fix build
radical Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[wasm] Quote filenames passed to emcc compile command line
  • Loading branch information
@radical
radical committed Jul 21, 2021
commit d61c225fb2fb4e31d5ccd9d953848e1882f5bbde
2 changes: 1 addition & 1 deletion src/tasks/WasmAppBuilder/EmccCompile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ bool ProcessSourceFile(ITaskItem srcItem)

try
{
string command = $"emcc {Arguments} -c -o {objFile} {srcFile}";
string command = $"emcc {Arguments} -c -o \"{objFile}\" \"{srcFile}\"";

// Log the command in a compact format which can be copy pasted
StringBuilder envStr = new StringBuilder(string.Empty);
Expand Down