Add s390x support in a few places in eng/native build scripts #56426
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
added
the
community-contribution
eng/native/functions.cmake
Outdated
There was a problem hiding this comment.
a nit: based on the condition on callsite if (CLR_CMAKE_USE_SYSTEM_LIBUNWIND), this is unused on platforms that use the in-tree libunwind (like linux-s390x).
If you would revert it, please leave a # comment on top of this function to make it clearer for future reader.
There was a problem hiding this comment.
Ah, actually if you intentionally want to use system libunwind, then you can pass ./build.sh -cmakeargs CLR_CMAKE_USE_SYSTEM_LIBUNWIND=1 or ./build.sh --portable=false. nvm, disregard please. :)
There was a problem hiding this comment.
Yes, exactly. This is just to allow that use case.
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue Details
|
* Make isMSBuildOnNETCoreSupported return true on s390x (fixes generating version headers) * Add s390x platform-specific library name in find_unwind_libs (enables linking against system-provided libunwind)
|
This would also be good to have in .NET 6, in particular the version headers change. |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1182727583 |
4 participants
Make isMSBuildOnNETCoreSupported return true on s390x
(fixes generating version headers)
Add s390x platform-specific library name in find_unwind_libs
(enables linking against system-provided libunwind)