[release/6.0] Add s390x support in a few places in eng/native build scripts #58366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make isMSBuildOnNETCoreSupported return true on s390x (fixes generating version headers) * Add s390x platform-specific library name in find_unwind_libs (enables linking against system-provided libunwind)
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
marek-safar
approved these changes
Aug 30, 2021
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsBackport of #56426 to release/6.0 Customer ImpactMake isMSBuildOnNETCoreSupported return true on s390x, this fixes generating version headers when building on s390x. Adds s390x platform-specific library name in find_unwind_libs, this enables linking against system-provided libunwind on s390x. TestingManual testing. RiskVery low, we don't build s390x in our official builds.
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #56426 to release/6.0
/cc @akoeplinger @uweigand
Customer Impact
Make isMSBuildOnNETCoreSupported return true on s390x, this fixes generating version headers when building on s390x.
Adds s390x platform-specific library name in find_unwind_libs, this enables linking against system-provided libunwind on s390x.
Testing
Manual testing.
Risk
Very low, we don't build s390x in our official builds.