Skip to content

Ecma edit for conv.ovf.<to type>.un. #56450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandreenko merged 9 commits into from
Aug 4, 2021
+1,246 −1
Merged

Ecma edit for conv.ovf.<to type>.un. #56450

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ec43add
Add a conv conformance test.
Jul 28, 2021
4c33ff7
Fix Ecma description.
Jul 28, 2021
da5491a
Fix the test.
Jul 28, 2021
03cbaca
Update docs/design/specs/Ecma-335-Augments.md
Jul 28, 2021
bc184e9
Disable VN optimizations on arm64 because of the bug.
Jul 29, 2021
8277151
add a new chapter.
Jul 29, 2021
53a92e4
fix space
Jul 30, 2021
b53ff87
Fix format.
Aug 2, 2021
3c28df2
exclude the test on mono
Aug 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix space
  • Loading branch information
Sergey committed Jul 30, 2021
commit 53a92e4e424cbd48c89cb0d08901bea9a3be37f2
2 changes: 1 addition & 1 deletion docs/design/specs/Ecma-335-Augments.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -921,7 +921,7 @@ conv.ovf.u4.un -> uint.MaxValue (0xFFFFFFFF)

However, the source of these opcodes can be a float value and it was not clear how in such case .un should be treated. The ECMA was saying: ""The item on the top of the stack is treated as an unsigned value before the conversion." but there was no definition of "treated" so the result of:
ldc.r4 -1
conv.ovf.i4.un
conv.ovf.i4.un
was ambiguous, it could treat -1 as 0xFFFFFFFF and return 0xFFFFFFFF or it could throw an overflow exception.

### III.3.19, conv.ovf.to type.un (page 354)
Copy link
Member

@davidwrighton davidwrighton Jul 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be put into a new section describing feature area. Effectively, each set of changes to the Ecma standard describes what the general impact is, and then there is the modification to the actual standardese. As it is this work is appended onto the covariant return types work, but really should be in its own chunk.

Copy link
Contributor Author

@sandreenko sandreenko Jul 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, I have added a new chapter and tried to add a justification for the change. I have not found a template for this, looks like different chapters are organized differently, please tell me if you want me to add issue numbers, link to the current standard, or something else.

Expand Down