Skip to content

Ecma edit for conv.ovf.<to type>.un. #56450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandreenko merged 9 commits into from
Aug 4, 2021
Merged

Ecma edit for conv.ovf.<to type>.un. #56450

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ec43add
Add a conv conformance test.
Jul 28, 2021
4c33ff7
Fix Ecma description.
Jul 28, 2021
da5491a
Fix the test.
Jul 28, 2021
03cbaca
Update docs/design/specs/Ecma-335-Augments.md
Jul 28, 2021
bc184e9
Disable VN optimizations on arm64 because of the bug.
Jul 29, 2021
8277151
add a new chapter.
Jul 29, 2021
53a92e4
fix space
Jul 30, 2021
b53ff87
Fix format.
Aug 2, 2021
3c28df2
exclude the test on mono
Aug 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix the test.
  • Loading branch information
Sergey committed Jul 29, 2021
commit da5491ab4bd689d9dc84c46bc3f80fedb1d5cdd9
33 changes: 18 additions & 15 deletions src/tests/JIT/IL_Conformance/Convert/TestConvertFromIntegral.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,17 +56,20 @@ static void GenerateTest<F, T>(F from, OpCode fromOpcode, OpCode convOpcode, boo
if (exceptionExpected)
{
failedCount++;
Console.WriteLine("No exception in " + name);
}
if (checkResult && !expectedTo.Equals(res))
{
failedCount++;
Console.WriteLine("Wrong result in " + name);
}
}
catch
{
if (!exceptionExpected)
{
failedCount++;
Console.WriteLine("Not expected exception in " + name);
}
}
}
Expand Down Expand Up @@ -736,10 +739,10 @@ static void TestConvertFromFloatToU2()
OpCode convNoOvf = OpCodes.Conv_U2;
GenerateTest<float, ushort>(1F, sourceOp, convNoOvf, DontExpectException, 1);
GenerateTest<float, ushort>(3.9F, sourceOp, convNoOvf, DontExpectException, 3);
GenerateTest<float, ushort>(-1F, sourceOp, convNoOvf, DontExpectException, ushort.MaxValue);
GenerateTest<float, ushort>(-1F, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour);

GenerateTest<float, ushort>(short.MaxValue, sourceOp, convNoOvf, DontExpectException, (ushort)short.MaxValue);
GenerateTest<float, ushort>(short.MinValue, sourceOp, convNoOvf, DontExpectException, (ushort)short.MaxValue + 1);
GenerateTest<float, ushort>(short.MinValue, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour);
GenerateTest<float, ushort>(ushort.MaxValue, sourceOp, convNoOvf, DontExpectException, ushort.MaxValue);
GenerateTest<float, ushort>(ushort.MinValue, sourceOp, convNoOvf, DontExpectException, ushort.MinValue);
GenerateTest<float, ushort>(long.MaxValue, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour);
Expand Down Expand Up @@ -799,8 +802,8 @@ static void TestConvertFromFloatToU4()

OpCode convNoOvf = OpCodes.Conv_U4;
GenerateTest<float, uint>(1, sourceOp, convNoOvf, DontExpectException, 1);
GenerateTest<float, uint>(-1, sourceOp, convNoOvf, DontExpectException, uint.MaxValue);
GenerateTest<float, uint>(int.MinValue, sourceOp, convNoOvf, DontExpectException, (uint)int.MaxValue + 1);
GenerateTest<float, uint>(-1, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour);
GenerateTest<float, uint>(int.MinValue, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour);
GenerateTest<float, uint>(uint.MinValue, sourceOp, convNoOvf, DontExpectException, uint.MinValue);
GenerateTest<float, uint>(long.MaxValue, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour);
GenerateTest<float, uint>(long.MinValue, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour);
Expand Down Expand Up @@ -855,9 +858,9 @@ static void TestConvertFromFloatToU8()

OpCode convNoOvf = OpCodes.Conv_U8;
GenerateTest<float, ulong>(1, sourceOp, convNoOvf, DontExpectException, 1);
GenerateTest<float, ulong>(-1, sourceOp, convNoOvf, DontExpectException, ulong.MaxValue);
GenerateTest<float, ulong>(int.MinValue, sourceOp, convNoOvf, DontExpectException, 0xffffffff80000000UL);
GenerateTest<float, ulong>(long.MinValue, sourceOp, convNoOvf, DontExpectException, (ulong)long.MaxValue + 1);
GenerateTest<float, ulong>(-1, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour);
GenerateTest<float, ulong>(int.MinValue, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour);
GenerateTest<float, ulong>(long.MinValue, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour);

OpCode convOvf = OpCodes.Conv_Ovf_U8;
GenerateTest<float, ulong>(1, sourceOp, convOvf, DontExpectException, 1);
Expand Down Expand Up @@ -1007,9 +1010,9 @@ static void TestConvertFromDoubleToU2()

OpCode convNoOvf = OpCodes.Conv_U2;
GenerateTest<double, ushort>(1, sourceOp, convNoOvf, DontExpectException, 1);
GenerateTest<double, ushort>(-1, sourceOp, convNoOvf, DontExpectException, ushort.MaxValue);
GenerateTest<double, ushort>(short.MaxValue, sourceOp, convNoOvf, DontExpectException, (ushort)short.MaxValue);
GenerateTest<double, ushort>(short.MinValue, sourceOp, convNoOvf, DontExpectException, (ushort)short.MaxValue + 1);
GenerateTest<double, ushort>(-1, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour);
GenerateTest<double, ushort>(short.MaxValue, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour);
GenerateTest<double, ushort>(short.MinValue, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour);
GenerateTest<double, ushort>(ushort.MaxValue, sourceOp, convNoOvf, DontExpectException, ushort.MaxValue);
GenerateTest<double, ushort>(ushort.MinValue, sourceOp, convNoOvf, DontExpectException, ushort.MinValue);
GenerateTest<double, ushort>(long.MaxValue, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour);
Expand Down Expand Up @@ -1078,8 +1081,8 @@ static void TestConvertFromDoubleToU4()

OpCode convNoOvf = OpCodes.Conv_U4;
GenerateTest<double, uint>(1, sourceOp, convNoOvf, DontExpectException, 1);
GenerateTest<double, uint>(-1, sourceOp, convNoOvf, DontExpectException, uint.MaxValue);
GenerateTest<double, uint>(int.MinValue, sourceOp, convNoOvf, DontExpectException, (uint)int.MaxValue + 1);
GenerateTest<double, uint>(-1, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour);
GenerateTest<double, uint>(int.MinValue, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour);
GenerateTest<double, uint>(uint.MinValue, sourceOp, convNoOvf, DontExpectException, uint.MinValue);
GenerateTest<double, uint>(long.MaxValue, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour);
GenerateTest<double, uint>(long.MinValue, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour);
Expand Down Expand Up @@ -1137,9 +1140,9 @@ static void TestConvertFromDoubleToU8()

OpCode convNoOvf = OpCodes.Conv_U8;
GenerateTest<double, ulong>(1, sourceOp, convNoOvf, DontExpectException, 1);
GenerateTest<double, ulong>(-1, sourceOp, convNoOvf, DontExpectException, ulong.MaxValue);
GenerateTest<double, ulong>(int.MinValue, sourceOp, convNoOvf, DontExpectException, 0xffffffff80000000UL);
GenerateTest<double, ulong>(long.MinValue, sourceOp, convNoOvf, DontExpectException, (ulong)long.MaxValue + 1);
GenerateTest<double, ulong>(-1, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour);
GenerateTest<double, ulong>(int.MinValue, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour);
GenerateTest<double, ulong>(long.MinValue, sourceOp, convNoOvf, DontExpectException, 0, UnspecifiedBehaviour);

OpCode convOvf = OpCodes.Conv_Ovf_U8;
GenerateTest<double, ulong>(1, sourceOp, convOvf, DontExpectException, 1);
Expand Down