Fixed StreamPipeReader.CopyToAsync #57943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Take the segment index into account when copying buffered data. This handles the case where ReadAsync has consumed a partial segment and then the same PipeReader instance is used to copy to a Stream and PipeWriter. - Added tests
ghost
added
the
davidfowl
requested review from
BrennanConroy,
halter73 and
stephentoub
and removed request for
BrennanConroy
stephentoub
reviewed
Aug 23, 2021
src/libraries/System.IO.Pipelines/src/System/IO/Pipelines/StreamPipeReader.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Aug 23, 2021
| [Fact] | ||
| public async Task CopyToAsyncStreamCopiesRemainderAfterReadingSome() | ||
| { | ||
| var buffer = Encoding.UTF8.GetBytes("Hello World"); |
Member
There was a problem hiding this comment.
Normally I'd comment on changing var => byte[], but it appears this file is already filled with such usage, so I won't say anything 😉
stephentoub
approved these changes
Aug 23, 2021
|
Hello @davidfowl! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
Member
Author
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1159922915 |
Member
Author
|
/backport to release/6.0-rc1 |
Contributor
|
Started backporting to release/6.0-rc1: https://github.com/dotnet/runtime/actions/runs/1159956239 |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57806