Skip to content

Fixed StreamPipeReader.CopyToAsync #57943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Aug 23, 2021
Merged

Fixed StreamPipeReader.CopyToAsync #57943

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4334f4
Fixed StreamPipeReader.CopyToAsync
davidfowl Aug 23, 2021
c1a3426
Always slice
davidfowl Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Always slice
  • Loading branch information
@davidfowl
davidfowl committed Aug 23, 2021
commit c1a34264474082dde71e907ef612268f6da125ec
4 changes: 2 additions & 2 deletions src/libraries/System.IO.Pipelines/src/System/IO/Pipelines/StreamPipeReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ public override async Task CopyToAsync(PipeWriter destination, CancellationToken
{
while (segment != null)
{
FlushResult flushResult = await destination.WriteAsync(segmentIndex > 0 ? segment.Memory.Slice(segmentIndex) : segment.Memory, tokenSource.Token).ConfigureAwait(false);
FlushResult flushResult = await destination.WriteAsync(segment.Memory.Slice(segmentIndex), tokenSource.Token).ConfigureAwait(false);

if (flushResult.IsCanceled)
{
Expand Down Expand Up @@ -460,7 +460,7 @@ public override async Task CopyToAsync(Stream destination, CancellationToken can
{
while (segment != null)
{
await destination.WriteAsync(segmentIndex > 0 ? segment.Memory.Slice(segmentIndex) : segment.Memory, tokenSource.Token).ConfigureAwait(false);
await destination.WriteAsync(segment.Memory.Slice(segmentIndex), tokenSource.Token).ConfigureAwait(false);

segment = segment.NextSegment;
segmentIndex = 0;
Expand Down