Skip to content

[release/6.0-rc1] [wasm][debugger] Fixing assert while debugging. #58032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steveisok merged 3 commits into from
Aug 24, 2021
Merged

[release/6.0-rc1] [wasm][debugger] Fixing assert while debugging. #58032

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5be5076
Fixing assert while debugging.
thaystg Aug 24, 2021
00a23bb
Adding test case.
thaystg Aug 24, 2021
b8aa313
Fixing test line.
thaystg Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adding test case.
  • Loading branch information
@thaystg
thaystg authored and github-actions committed Aug 24, 2021
commit 00a23bb5b3ba858a3d618150766327cbbf21e922
7 changes: 6 additions & 1 deletion src/mono/wasm/debugger/DebuggerTestSuite/CustomViewTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public async Task UsingDebuggerDisplay()
[Fact]
public async Task UsingDebuggerTypeProxy()
{
var bp = await SetBreakpointInMethod("debugger-test.dll", "DebuggerTests.DebuggerCustomViewTest", "run", 6);
var bp = await SetBreakpointInMethod("debugger-test.dll", "DebuggerTests.DebuggerCustomViewTest", "run", 12);
var pause_location = await EvaluateAndCheck(
"window.setTimeout(function() { invoke_static_method ('[debugger-test] DebuggerTests.DebuggerCustomViewTest:run'); }, 1);",
"dotnet://debugger-test.dll/debugger-custom-view-test.cs",
Expand All @@ -54,8 +54,13 @@ public async Task UsingDebuggerTypeProxy()
props = await GetObjectOnFrame(frame, "b");
CheckString(props, "Val2", "one");

CheckObject(locals, "openWith", "System.Collections.Generic.Dictionary<string, string>", description: "Count = 3");
props = await GetObjectOnFrame(frame, "openWith");
Assert.Equal(1, props.Count());

await EvaluateOnCallFrameAndCheck(frame["callFrameId"].Value<string>(),
("listToTestToList.ToList()", TObject("System.Collections.Generic.List<int>", description: "Count = 11")));

}
}
}
8 changes: 8 additions & 0 deletions src/mono/wasm/debugger/tests/debugger-test/debugger-custom-view-test.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,14 @@ public static void run()
var c = new DebuggerDisplayMethodTest();
List<int> myList = new List<int>{ 1, 2, 3, 4 };
var listToTestToList = System.Linq.Enumerable.Range(1, 11);

Dictionary<string, string> openWith = new Dictionary<string, string>();

openWith.Add("txt", "notepad");
openWith.Add("bmp", "paint");
openWith.Add("dib", "paint");
Console.WriteLine("break here");

Console.WriteLine("break here");
}
}
Expand Down