Skip to content

[release/6.0-rc1] [wasm][debugger] Fixing assert while debugging. #58032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steveisok merged 3 commits into from
Aug 24, 2021
Merged

[release/6.0-rc1] [wasm][debugger] Fixing assert while debugging. #58032

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5be5076
Fixing assert while debugging.
thaystg Aug 24, 2021
00a23bb
Adding test case.
thaystg Aug 24, 2021
b8aa313
Fixing test line.
thaystg Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fixing assert while debugging.
  • Loading branch information
@thaystg
thaystg authored and github-actions committed Aug 24, 2021
commit 5be5076cac5d86aa2b318d42bf289f9543538258
8 changes: 7 additions & 1 deletion src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2280,10 +2280,16 @@ public async Task<JArray> GetValuesFromDebuggerProxyAttribute(SessionId sessionI
var assemblyNameArg = await GetFullAssemblyName(sessionId, assemblyIdArg, token);
var classNameArg = await GetTypeNameOriginal(sessionId, genericTypeArgs[k], token);
typeToSearch += classNameArg +", " + assemblyNameArg;
if (k + 1 < genericTypeArgs.Count)
typeToSearch += "], [";
else
typeToSearch += "]";
}
typeToSearch += "]]";
typeToSearch += "]";
typeToSearch += ", " + assemblyName;
var genericTypeId = await GetTypeByName(sessionId, typeToSearch, token);
if (genericTypeId < 0)
return null;
methodId = await GetMethodIdByName(sessionId, genericTypeId, ".ctor", token);
}
else
Expand Down