Skip to content

[release/6.0] Fix fgValueNumberArrIndexVal for wide reads #58427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffschwMSFT merged 4 commits into from
Aug 31, 2021
Merged

[release/6.0] Fix fgValueNumberArrIndexVal for wide reads #58427

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1937982
fix fgValueNumberArrIndexVal for wide reads
EgorBo Aug 28, 2021
d92ae2a
Update test
EgorBo Aug 28, 2021
486574b
Fix regressions
EgorBo Aug 28, 2021
d49e741
Update valuenum.cpp
EgorBo Aug 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix regressions
  • Loading branch information
@EgorBo
EgorBo authored and github-actions committed Aug 31, 2021
commit 486574b3a7bf28ebed8dafa559e49d148536eb23
3 changes: 2 additions & 1 deletion src/coreclr/jit/valuenum.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4242,8 +4242,9 @@ ValueNum Compiler::fgValueNumberArrIndexVal(GenTree* tree,
var_types elemTyp = DecodeElemType(elemTypeEq);
var_types indType = (tree == nullptr) ? elemTyp : tree->TypeGet();
ValueNum selectedElem;
unsigned elemWidth = varTypeIsStruct(elemTyp) ? info.compCompHnd->getClassSize(elemTypeEq) : genTypeSize(elemTyp);

if ((fldSeq == FieldSeqStore::NotAField()) || (genTypeSize(indType) > genTypeSize(elemTyp)))
if ((fldSeq == FieldSeqStore::NotAField()) || (genTypeSize(indType) > elemWidth))
{
// This doesn't represent a proper array access
JITDUMP(" *** Not a proper arrray access encountered in fgValueNumberArrIndexVal\n");
Expand Down