Skip to content

[release/6.0] Skip allocation for ZeroInit writeThru intervals #58767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffschwMSFT merged 3 commits into from
Sep 7, 2021
Merged

[release/6.0] Skip allocation for ZeroInit writeThru intervals #58767

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0095a5
Do not allocate register if ZeroInit/EHWriteThru
kunalspathak Sep 4, 2021
f2fa482
Update the comments about zero-init heuristics
kunalspathak Sep 4, 2021
60cbf4d
jit format
kunalspathak Sep 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Do not allocate register if ZeroInit/EHWriteThru
  • Loading branch information
@kunalspathak
kunalspathak authored and github-actions committed Sep 7, 2021
commit d0095a563064ebb5e613416374b3845a7f576a06
6 changes: 6 additions & 0 deletions src/coreclr/jit/lsra.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4945,6 +4945,12 @@ void LinearScan::allocateRegisters()
// it to a different register file.
allocate = false;
}
else if ((currentInterval->isWriteThru) && (refType == RefTypeZeroInit))
{
// For RefTypeZeroInit which is a write thru, there is no need to allocate register
// right away. It can be assigned when actually definition occurs.
allocate = false;
}
if (!allocate)
{
INDEBUG(dumpLsraAllocationEvent(LSRA_EVENT_NO_ENTRY_REG_ALLOCATED, currentInterval));
Expand Down