Change channel passed to ci_setup to track runtime branch #59070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change we move to specifing the channel that is passed to ci_setup, instead of it always being main. The allows us to have the runtime branch help decide the correct version of the sdk that we should pull down with dotnet-install. This means that going forward, we will need to have channels that match the names of all branches that we plan to run from the runtime side. If we do not, the sdk installation step will fail during ci_setup.
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsWith this change we move to specifing the channel that is passed to ci_setup,
|
This was referenced Sep 14, 2021
Member
Author
|
@billwert PTAL |
billwert
approved these changes
Sep 15, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we move to specifing the channel that is passed to ci_setup,
instead of it always being main. The allows us to have the runtime branch
help decide the correct version of the sdk that we should pull down with
dotnet-install. This means that going forward, we will need to have channels
that match the names of all branches that we plan to run from the runtime
side. If we do not, the sdk installation step will fail during ci_setup.