Skip to content

Conversation

@radical
Copy link
Member

@radical radical commented Sep 17, 2021

.. and update the BlazorOverwrite.targets to match. (from sdk commit: e89f3d77dbd6f41890b10eafd98505261fa63755)

And apply the fix from dotnet/sdk#21104 for #59255 to BlazorOverwrite.targets.

Customer impact

No customer impact, since is a test only change. BlazorOverwrite.targets is used only for tests.

Testing

Manually tested, and adds a new test.

Risk

None, since this is a test only change

.. and update the BlazorOverwrite.targets to match.
(from sdk commit: e89f3d77dbd6f41890b10eafd98505261fa63755)
.. and update BlazorOverwrite.targets to include the fix from
dotnet/sdk#21104 .
@radical radical added arch-wasm WebAssembly architecture area-Build-mono labels Sep 17, 2021
@ghost
Copy link

ghost commented Sep 17, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

.. and update the BlazorOverwrite.targets to match. (from sdk commit: e89f3d77dbd6f41890b10eafd98505261fa63755)

And apply the fix from dotnet/sdk#21104 for #59255 to BlazorOverwrite.targets.

Customer impact

No customer impact, since is a test only change. BlazorOverwrite.targets is used only for tests.

Testing

Manually tested, and adds a new test.

Risk

None, since this is a test only change

Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono

Milestone: -

@radical
Copy link
Member Author

radical commented Sep 17, 2021

@radical radical requested a review from lewing September 17, 2021 20:03
@radical
Copy link
Member Author

radical commented Sep 25, 2021

Taking the changes from here into #59486 .

@radical radical closed this Sep 25, 2021
@radical radical deleted the add-test-blazor-fix branch September 25, 2021 21:31
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Build-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants