-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[release/6.0.1xx-rc2] BlazorWasm: Fix including the target assembly #21104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0.1xx-rc2] BlazorWasm: Fix including the target assembly #21104
Conversation
.. and update BlazorOverwrite.targets to include the fix from dotnet/sdk#21104 .
SteveSandersonMS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense based on what I saw before. Will this make it able to pick up DllImport from ProjectReferences too (if it didn’t already)?
Can you elaborate on this? |
|
I just wanted to check that the issue that prevented it seeing your main assembly didn’t also prevent it from seeing the assemblies of other projects in your solution. We know the feature works for PackageReference dependencies, but does it work for ProjectReference dependencies? Has that been tried out? Hope that makes sense! |
Yes, dllimports in referenced projects would get scanned for pinvokes during the native build. Currently, the native library won't get automatically included in the app project though. IOW, you would need an explicit |
Package authors could already fix that themselves by including some MSBuild in their package that adds a |
|
@marcpopMSFT what is the process to get this in rc2 now? |
Fixes dotnet/runtime#59255 . (cherry picked from commit f70cf06)
Use
$(IntermediateAssembly)when gathering files for wasm build.Fixes dotnet/runtime#59255 .