Skip to content

Revise descriptions of VS workloads, and add missing ones #59698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
directhex merged 2 commits into from
Sep 29, 2021
Merged

Revise descriptions of VS workloads, and add missing ones #59698

directhex merged 2 commits into from
Sep 29, 2021

Conversation

@directhex
Copy link
Contributor

@directhex directhex commented Sep 28, 2021

No description provided.

@runfoapp runfoapp bot mentioned this pull request Sep 28, 2021
Closed
joeloff
joeloff reviewed Sep 28, 2021
View reviewed changes
src/workloads/workloads.csproj Outdated
<ComponentResources Include="runtimes-ios" Title=".NET iOS Runtimes"
Description=".NET runtime components for iOS execution."/>
<ComponentResources Include="runtimes-tvos" Title=".NET tvOS Build Tools"
Description=".NET runtime components for tvOS execution.."/>
Copy link
Member

@joeloff joeloff Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra "."

@directhex directhex merged commit aa7a125 into dotnet:main Sep 29, 2021
@directhex
Copy link
Contributor Author

directhex commented Sep 29, 2021

/backport to release/6.0-rc2

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2021

Started backporting to release/6.0-rc2: https://github.com/dotnet/runtime/actions/runs/1286912852

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2021

@directhex an error occurred while backporting to release/6.0-rc2, please check the run log for details!

Error: @directhex is not a repo collaborator, backporting is not allowed.

@steveisok
Copy link
Member

steveisok commented Sep 29, 2021

/backport to release/6.0-rc2

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2021

Started backporting to release/6.0-rc2: https://github.com/dotnet/runtime/actions/runs/1286958547

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2021

@steveisok an error occurred while backporting to release/6.0-rc2, please check the run log for details!

Error: @steveisok is not a repo collaborator, backporting is not allowed.

@runfoapp runfoapp bot mentioned this pull request Sep 30, 2021
Closed
@akoeplinger
Copy link
Member

akoeplinger commented Oct 1, 2021

/backport to release/6.0-rc2

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2021

Started backporting to release/6.0-rc2: https://github.com/dotnet/runtime/actions/runs/1296315351

@github-actions github-actions bot mentioned this pull request Oct 1, 2021
Closed
@lewing
Copy link
Member

lewing commented Oct 25, 2021

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2021

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1382081618

@github-actions github-actions bot mentioned this pull request Oct 25, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Nov 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisok steveisok steveisok approved these changes

@joeloff joeloff joeloff approved these changes

Assignees

No one assigned

Labels

area-Build-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@directhex @steveisok @akoeplinger @lewing @joeloff