Skip to content

Update HostFactoryResolver to account for lack of application name with new host pattern #59743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ajcvickers wants to merge 1 commit into from
Closed

Update HostFactoryResolver to account for lack of application name with new host pattern #59743

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update HostFactoryResolver to account for lack of application name wi… 
…th new host pattern

Based on dotnet/efcore#26198

The fix should go here, rather than in EF Core, because then anybody using this code will get the fixed behavior. I have tested this locally and it fixes https://github.com/dotnet/efcore/issues/26177. However tests should be added to this repo.
  • Loading branch information
@ajcvickers
ajcvickers authored Sep 29, 2021
commit 281736979cb0c59f4f17b1e415ee59d3d6d2ccd9
9 changes: 9 additions & 0 deletions src/libraries/Microsoft.Extensions.HostFactoryResolver/src/HostFactoryResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.Linq;
using System.Reflection;
using System.Threading;
using System.Threading.Tasks;
Expand Down Expand Up @@ -144,6 +145,14 @@ private static bool IsFactory<TReturn>(MethodInfo? factory)
{
return args =>
{
static bool IsApplicationNameArg(string arg)
=> arg.Equals("--applicationName", StringComparison.OrdinalIgnoreCase) ||
arg.Equals("/applicationName", StringComparison.OrdinalIgnoreCase);

args = args.Any(arg => IsApplicationNameArg(arg)) || assembly.FullName is null
Copy link
Member

@eerhardt eerhardt Sep 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When is assembly.FullName null?

Copy link
Member

@davidfowl davidfowl Sep 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you're writing unit tests 😄

? args
: args.Concat(new[] { "--applicationName", assembly.FullName }).ToArray();

var host = hostFactory(args);
return GetServiceProvider(host);
};
Expand Down