DotNetHost packages are not created during source-build #60575
Conversation
The subset `host.pkg` is not producing the DotNetHost* NuGet packages. This is because the "Pack" target is getting invoked on the pkgprojs, but pkgprojs expect the "Build" target to be called. Since the "Pack" target is overriden in the Directory.Build.targets to be empty, no one is calling the "Build" target on the pkgprojs. In an official build, a later subset `packs.tests` comes through and builds `Microsoft.DotNet.CoreSetup.Packaging.Tests.csproj`, which explicitly calls "Build" on the pkgprojs. So official builds still get these packages produced. In source-build, we are no longer building the `packs.tests` subset, so the packages are not produced.
eerhardt
requested review from
ViktorHofer,
jkoritzinsky,
joperezr and
safern
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
I assume it is "too late" for The change has the risk of breaking the official build in I was just going to patch this in for |
|
For main the long term fix is to switch away from pkgproj to the NuGet Pack task, tracked via dotnet/arcade#7783. |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1356397959 |
nit: Since dotnet/arcade@74cdaee, the above statement is technically not true anymore as the Pack target - as long as it's not overridden, which it is in this case - is a fine entry point as well. |
we can get the change in if its safe |
|
cc @mmitche |
ghost
locked as resolved and limited conversation to collaborators
6 participants
The subset
host.pkgis not producing the DotNetHost* NuGet packages. This is because the "Pack" target is getting invoked on the pkgprojs, but pkgprojs expect the "Build" target to be called. Since the "Pack" target is overriden in the Directory.Build.targets to be empty, no one is calling the "Build" target on the pkgprojs.In an official build, a later subset
packs.testscomes through and buildsMicrosoft.DotNet.CoreSetup.Packaging.Tests.csproj, which explicitly calls "Build" on the pkgprojs. So official builds still get these packages produced.In source-build, we are no longer building the
packs.testssubset, so the packages are not produced.