Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
DotNetHost packages are not created during source-build
The subset `host.pkg` is not producing the DotNetHost* NuGet packages. This is because the "Pack" target is getting invoked on the pkgprojs, but pkgprojs expect the "Build" target to be called. Since the "Pack" target is overriden in the Directory.Build.targets to be empty, no one is calling the "Build" target on the pkgprojs.

In an official build, a later subset `packs.tests` comes through and builds `Microsoft.DotNet.CoreSetup.Packaging.Tests.csproj`, which explicitly calls "Build" on the pkgprojs. So official builds still get these packages produced.

In source-build, we are no longer building the `packs.tests` subset, so the packages are not produced.
  • Loading branch information
eerhardt committed Oct 18, 2021
commit 9b1f6b655adc33b569436e7bccd2a673b2af5e6c
2 changes: 1 addition & 1 deletion src/installer/Directory.Build.targets
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@
<Import Project="..\..\Directory.Build.targets" />

<!-- Provide default targets which can be hooked onto or overridden as necessary -->
<Target Name="Pack" />
<Target Name="Pack" DependsOnTargets="Build" />
</Project>