Skip to content

[release/5.0] accept empty realm for digest auth (#56369) #61203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anipik merged 4 commits into from
Nov 8, 2021
Merged

[release/5.0] accept empty realm for digest auth (#56369) #61203

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8e4b652
accept empty realm for digest auth (#56369)
lucabompani Jul 28, 2021
9b8e3ce
accept empty realm for digest auth (#56369)
lucabompani Jul 29, 2021
0c73003
accept empty realm for digest auth (#56369)
lucabompani Jul 29, 2021
da6f70e
accept empty realm for digest auth (#56369)
lucabompani Jul 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
accept empty realm for digest auth (#56369)
  • Loading branch information
@lucabompani
lucabompani authored and github-actions committed Nov 4, 2021
commit 0c73003f3ced415a687105d668d9549017cdbed7
4 changes: 2 additions & 2 deletions ...ies/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/AuthenticationHelper.Digest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,9 +408,9 @@ private unsafe void Parse(string challenge)
// Ensure value is valid.
// Opaque, Domain and Realm can have empty string
if (value == string.Empty &&
(!key.Equals(Opaque, StringComparison.OrdinalIgnoreCase) &&
!key.Equals(Opaque, StringComparison.OrdinalIgnoreCase) &&
!key.Equals(Domain, StringComparison.OrdinalIgnoreCase) &&
!key.Equals(Realm, StringComparison.OrdinalIgnoreCase)))
!key.Equals(Realm, StringComparison.OrdinalIgnoreCase))
break;

// Add the key-value pair to Parameters.
Expand Down