Fix lazy-initialization of Trace.s_correlationManager to be thread-safe #62640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If two threads race to initialize it, one may end up overwriting the others, which means state pushed onto the losing thread's stack might end up disappearing.
ghost
added
the
|
Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti, @safern Issue DetailsIf two threads race to initialize it, one may end up overwriting the others, which means state pushed onto the losing thread's stack might end up disappearing. Fixes #50480
|
Member
Author
|
Thanks, @safern |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If two threads race to initialize it, one may end up overwriting the other's, which means state pushed onto the losing thread's stack might end up disappearing.
Fixes #50480