.NET number values such as positive and negative infinity cannot be written as valid JSON. #62690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-text-json Issue DetailsSee issue #48926. /cc @layomia
|
layomia
reviewed
Dec 13, 2021
Contributor
layomia
left a comment
layomia
left a comment
There was a problem hiding this comment.
This PR should also update the exception message as suggested in #48926 (comment).
Co-authored-by: Layomi Akinrinade <[email protected]>
layomia
reviewed
Dec 13, 2021
deeprobin
commented
Dec 13, 2021
layomia
reviewed
Dec 13, 2021
Co-authored-by: Layomi Akinrinade <[email protected]>
krwq
reviewed
Dec 14, 2021
Co-authored-by: Krzysztof Wicher <[email protected]>
layomia
reviewed
Dec 20, 2021
layomia
reviewed
Dec 20, 2021
layomia
reviewed
Dec 20, 2021
Contributor
layomia
left a comment
layomia
left a comment
There was a problem hiding this comment.
Couple more comments, then LGTM.
Co-authored-by: Layomi Akinrinade <[email protected]>
layomia
reviewed
Dec 22, 2021
Contributor
Author
dotnet/dotnet-api-docs#7488 was merged, so I think this could be merged as well |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #48926.
/cc @layomia
/cc @GrabYourPitchforks