[AOT] Use .short directive instead of .hword
#64561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xamarin.Android is trying to (partially) switch to LLVM-based toolchain and it appears that the `llvm-mc` assembler doesn't accept `.hword` as a valid directive for x86 targets. Since it's an alias for `.short`, which works fine, the change should be safe across all the architectures supported by AOT.
grendello
requested review from
SamMonoRT,
imhameed,
lambdageek and
vargaz
as code owners
ghost
added
the
community-contribution
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
vargaz
approved these changes
Feb 1, 2022
imhameed
approved these changes
Feb 1, 2022
Member
|
/backport to release/6.0 |
Member
|
/azp run sync-runtime-to-mono |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1779808098 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Feb 1, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xamarin.Android is trying to (partially) switch to LLVM-based toolchain
and it appears that the
llvm-mcassembler doesn't accept.hwordas avalid directive for x86 targets. Since it's an alias for
.short,which works fine, the change should be safe across all the architectures
supported by AOT.