[release/6.0] [AOT] Use .short directive instead of .hword
#64637
Conversation
Xamarin.Android is trying to (partially) switch to LLVM-based toolchain and it appears that the `llvm-mc` assembler doesn't accept `.hword` as a valid directive for x86 targets. Since it's an alias for `.short`, which works fine, the change should be safe across all the architectures supported by AOT.
github-actions
bot
requested review from
SamMonoRT,
imhameed,
lambdageek and
vargaz
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
akoeplinger
added
Servicing-consider
|
Tagging subscribers to 'arch-android': @steveisok, @akoeplinger Issue DetailsBackport of #64561 to release/6.0 Customer ImpactXamarin.Android is trying to (partially) switch to LLVM-based toolchain TestingManual and CI testing. RiskLow. Since
|
leecow
added
Servicing-approved
|
@akoeplinger can we get a signoff here so that I can merge? |
|
@safern done! |
ghost
locked as resolved and limited conversation to collaborators
Backport of #64561 to release/6.0
/cc @akoeplinger @grendello
Customer Impact
Xamarin.Android is trying to (partially) switch to LLVM-based toolchain
and it appears that the
llvm-mcassembler doesn't accept.hwordas avalid directive for x86 targets.
Testing
Manual and CI testing.
Risk
Low. Since
.hwordis an alias for.short, which works fine, the change should be safe across all the architecturessupported by AOT.